Bugfix/redis4 cluster initialization #293
Conversation
Major refactoring (0.2.0)
Release 1.2.0
…anted log messages
PUBSUB commands added to redis-py in 3f4ac6, which according to Redis docs (https://redis.io/commands/pubsub, https://redis.io/topics/pubsub) can be sent to any node
Added parsing callbacks for all three `PUBSUB` sub-commands, which give these commands the same behaviour as in single-node Redis & `redis-py`. **Note** that the switches on each method to *not* aggregate responses into one appear to not be bubbling through to the callback.
…BSUB commands ``**kwargs`` is not bubbled through to all result callbacks to enable the toggle to reach the PUBSUB parsing methods in `utils.py`. This adds `**kwargs` to the `StrictRedisCluster._merge_result` method's signature.
Now tests on ordered list
* Using `string_keys_to_dict` for all RESULT_CALLBACKS * Simplified `subscribe` calls in test cases to remove unnecessary variable declarations * Remove change to `_random_good_hashslot_key` which was not related to PR * Add `set_result_callback(command, callback)` to match Redis-Py feature `set_response_callback` * Skipping redis-py versions below `2.10.6` for `PUBSUB` tests * Add docstring to `TestPubSubPubSubSubcommands` class * Adding docs on pubsub subcommands, and to release notes.
…0.0.1 instead of node hostname
|
@afshinrudgar Why open a second Pull request when you had one open? Also you have some problems with where you created your brnch from as you should not see all of these |
|
@afshinrudgar Again, please read the last 2 comments in your previous pull request before you continue with this pull request and anser it. I am currently not inclined to merge this PR as it solves a problem in the wrong way/location. Please respond to either PR with why this should be done here and not solved with a proper depoyment of the redis-server. Without a good reason for that question, i probably won't merge this. |
4 similar comments
1 similar comment
|
@afshinrudgar Next time you find an issue. Please open up an issue describing it before submitting a PR. If the issue is not really and issue or not relevant/related to this project, there is no need to put down any time in solving it, saving everyone time and effort :) |
Bug in redis cluster initialization with redis 4