This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
threaded pipeline #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -318,3 +312,19 @@ def inner(*args, **kwargs): | |||
| StrictClusterPipeline.sunion = block_pipeline_command(StrictRedis.sunion) | |||
| StrictClusterPipeline.sunionstore = block_pipeline_command(StrictRedis.sunionstore) | |||
| StrictClusterPipeline.pfmerge = block_pipeline_command(StrictRedis.pfmerge) | |||
|
|
|||
|
|
|||
| class Worker(threading.Thread): | |||
There was a problem hiding this comment.
Please add some docstring here what the purpose of this worker class is.
There was a problem hiding this comment.
ping, this was hidden when you rebased :]
72squared
force-pushed
the
unstable-pipe-thread
branch
from
e7ef237
to
e06cfa8
Compare
… want greenlets instead of threads.
72squared
force-pushed
the
unstable-pipe-thread
branch
from
e06cfa8
to
61fe59b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was sloppy and committed this based on the assumption that you'll merge in unstable-eval. I can rebase and clean this up as needed but figured you'd want to get this asap so you can leave feedback.