Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major documents update #1271

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Major documents update #1271

merged 1 commit into from
Feb 8, 2024

Conversation

vmarseguerra
Copy link
Contributor

@vmarseguerra vmarseguerra commented Jan 14, 2024

The main goal is to improve how documents are handled in the API (creation, import, validation, fetching)
Most notable changes are:

  • Convert the document BBS regions into their ISO counterpart (countries and regions)
  • Refactor and simplify document output format
  • Add more documents field in the DB export file

Other important changes:

  • Regroup logic to populate cave, massif, document, organization sub entities
  • Refactor some simple caver and document controller
  • Remove redundant try/catch in controllers
  • Refactor Document CSV import service
  • Refactor csvHelper

Database related changes:

  • Integrate old database migration into the table definition
  • Add a 2 join tables for document ISO and countries
  • Migrate OR remove old document DB fields: ref_bbs, id_massif, id_author_caver, id_author_grotto

As logstash.conf has been modified it will be required to manualy update it on the ES server

This PR is linked to the front PR: GrottoCenter/grottocenter-front#940

@urien
Copy link
Contributor

urien commented Jan 14, 2024

Merci Vincent,
Je suis incapable d'avoir un regard sur ce code

@vmarseguerra
Copy link
Contributor Author

Si veut tu peux vérifier que tout te semble correct au niveau fonctionnel sur https://grottocenter-beta.grottomap.org/
Notamment:

  • La visualisation d'un document
  • La création d'un document
  • L'import de documents en CSV

La base de donné étant dupliqué il n'y a pas de risque de polluer la base de prod

@urien
Copy link
Contributor

urien commented Jan 14, 2024

Je viens d'adresser un message à toutes les personnes qui pourraient être intéressées à donner leur avis.
Je vais passer du temps a faire des tests et mettre les retours que j'aurais ici

Copy link
Contributor

@bsoufflet bsoufflet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow ! Belle PR !
Je l'ai survolé et rien ne moe choque ;) Je n'ai malheureusement pas suffisamment de temps en ce moment pour faire une vrai code review qui prendrait plusieurs heures pour une PR comme cela !
@urien me disait au tęléphone que l'on corrigera au fil de l'eau les potentielle régression lié à ces changements et cela me convient.

@vmarseguerra vmarseguerra merged commit 65fbd3d into develop Feb 8, 2024
3 of 5 checks passed
@vmarseguerra vmarseguerra deleted the document-refactor branch February 8, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants