Merge pull request #635 from tygriffin/fix-cache-key

Fix cache key
Growstuff · Jan 15, 2015 · 181c36c · 181c36c
2 parents a510489 + 36ac0b7
commit 181c36c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb
@@ -57,7 +57,7 @@ def create
 
     respond_to do |format|
       if @comment.save
-        format.html { redirect_to @comment.post, notice: 'Comment was successfully created.' }
+        format.html { redirect_to @comment.post, notice: "Comment was successfully created." }
         format.json { render json: @comment, status: :created, location: @comment }
       else
         format.html { render action: "new" }

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -24,10 +24,11 @@ def forex_link(price)
       :target => "_blank"
   end 
 
-  def cache_key_for(klass)
+  # Produces a cache key for uniquely identifying cached fragments.
+  def cache_key_for(klass, identifier="all")
     count          = klass.count
     max_updated_at = klass.maximum(:updated_at).try(:utc).try(:to_s, :number)
-    "#{klass.name.downcase.pluralize}/all-#{count}-#{max_updated_at}"
+    "#{klass.name.downcase.pluralize}/#{identifier}-#{count}-#{max_updated_at}"
   end
 
 end

diff --git a/app/views/home/_crops.html.haml b/app/views/home/_crops.html.haml
@@ -1,6 +1,6 @@
 .row
   .col-md-6.hidden-xs
-    - cache cache_key_for(Crop), :expires_in => 1.day do
+    - cache cache_key_for(Crop, 'interesting'), :expires_in => 1.day do
       %h2= t('.our_crops')
       - Crop.interesting.each do |c|
         .col-md-3{:style => 'margin:0px; padding: 3px'}
@@ -13,7 +13,7 @@
 
 .row
   .col-md-12
-    - cache cache_key_for(Crop) do
+    - cache cache_key_for(Crop, 'recent') do
       %p{ :style => 'margin-top: 11.25px' }
         %strong
           #{t('.recently_added')}: