Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to ruby 3.1.4 #3330

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Bump to ruby 3.1.4 #3330

merged 3 commits into from
Apr 28, 2023

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Apr 27, 2023

Fix #3315

Does it work for Heroku? Supposedly https://devcenter.heroku.com/changelog-items/2561 yes

  • Successful staging deploy via heroku using this version

For #3315

Does it work for Heroku? Who knows!
@CloCkWeRX CloCkWeRX requested a review from cesy April 27, 2023 09:54
Gemfile.lock Outdated
@@ -749,7 +749,7 @@ DEPENDENCIES
xmlrpc

RUBY VERSION
ruby 3.1.3p185
ruby 3.1.4p223
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected an indentation at 4 instead of at 3.

Making codeclimate happy manually
Copy link
Member

@cesy cesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy now we've solved codeclimate. Long term we may need to find a way to get it to have different criteria for this one line in this file as it's auto-generated with three spaces instead of four.

@CloCkWeRX CloCkWeRX merged commit cc5ad66 into dev Apr 28, 2023
8 checks passed
@CloCkWeRX CloCkWeRX deleted the CloCkWeRX-patch-1 branch April 28, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codespace minor points
2 participants