Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test to add a user with same email twice #74

Merged
merged 3 commits into from
May 30, 2018
Merged

Create test to add a user with same email twice #74

merged 3 commits into from
May 30, 2018

Conversation

bartero
Copy link

@bartero bartero commented May 8, 2018

No description provided.

@bartero bartero self-assigned this May 8, 2018
@coveralls
Copy link

coveralls commented May 8, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 84.846% when pulling c2b41d9 on user_job_test_unique_email into c3c617d on master.

AdrianSkierniewski
AdrianSkierniewski previously approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@AdrianSkierniewski AdrianSkierniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

PSkierniewski
PSkierniewski requested changes May 30, 2018
View reviewed changes
tests/unit/jobs/UserJobsTest.php Outdated
'first_name' => 'John2',
'last_name' => 'Doe2',
]));
} catch (QueryException $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should catch Exception here and assert that it's a QueryException instance.

PSkierniewski
PSkierniewski approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@PSkierniewski PSkierniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PSkierniewski PSkierniewski merged commit 7de649b into master May 30, 2018
@PSkierniewski PSkierniewski deleted the user_job_test_unique_email branch May 30, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSkierniewski PSkierniewski PSkierniewski approved these changes

@AdrianSkierniewski AdrianSkierniewski AdrianSkierniewski left review comments

Assignees

@bartero bartero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bartero @coveralls @AdrianSkierniewski @PSkierniewski