tests #22
Merged
tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $I->canSee('And she heard every moment Alice.'); | ||
| $I->canSee('Gryphon is, look at me like a tunnel for some way, and then I\'ll tell you his history'); | ||
| $I->canSee('Posted by Vern Lind'); | ||
| $I->canSee('on 26-11-2015 - 05:02'); |
There was a problem hiding this comment.
We shouldn't rely on hard coded dates
|
We should probably use fixtures instead db dump based on random faker content. |
|
But first you'd need to solve conflicts |
| 'parentId' => $category->id, | ||
| 'translations' => [ | ||
| 'langCode' => 'en', | ||
| 'title' => 'ZZZ', |
There was a problem hiding this comment.
I think that we should use title with meaning, rather than some random letters, eg. "Sticky Content"
|
@PSkierniewski ptal |
|
@MateuszUrbanowicz Some tests are still failing, fix them and 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.