Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent hangs during HTTP downloads #60

Closed
dalehenrich opened this issue Mar 22, 2015 · 7 comments
Closed

Apparent hangs during HTTP downloads #60

dalehenrich opened this issue Mar 22, 2015 · 7 comments

Comments

@dalehenrich
Copy link
Member

Without going too deeply into the gory details, this morning the internet was VERY slow and my gsDevKitHome builds were completely stalled because http downloads from certain sites were glacial ... @martinmcclure was able to point a finger at slow comcast routers. curl and wget were having trouble as well, but they weren't hanging like my build, so I looked into the timeout situation and found that HTTPSocket>>getResponseUpTo:ignoring: and HTTPSocket>>getResponseUpTo: had 120000ms timeouts ... they've been that way for 8 years, but 2 minute timeouts are a bit much .... when I cranked the timeout down to a more reasonable 500 ms I was able to finish my builds ... so I'll push this change up ... today

dalehenrich pushed a commit to glassdb/glass that referenced this issue Mar 22, 2015
@krono
Copy link
Member

krono commented Mar 22, 2015

You thinks that's worth back-porting to squeak?

@dalehenrich
Copy link
Member Author

Is that the default timeout for Squeak? If so, then I think that it's worth putting into HTTPSocket ... it is very possible that I bumped the timeout up a long time ago ... never expecting that 2 we'd hit 2 minutes of hang time:)

@dalehenrich
Copy link
Member Author

clean build and I've used this branch for a number of builds and for the most part the subsequent connections complete very quickly so I haven't experienced a downside to half second delays

dalehenrich added a commit to glassdb/glass that referenced this issue Mar 23, 2015
@krono
Copy link
Member

krono commented Mar 23, 2015

(the code is very different in Squeak currently, so this does not apply. Thanks nevertheless :)

dalehenrich added a commit to glassdb/glass that referenced this issue Mar 23, 2015
@dalehenrich
Copy link
Member Author

neglected to include path for Squeak and Squeak.v3 packages ... didn't bump version for Squeak.v32 package ...

@dalehenrich dalehenrich reopened this Mar 23, 2015
dalehenrich added a commit to glassdb/glass that referenced this issue Mar 23, 2015
…early not long enough ... going with 20 seconds for now ... I see where a different strategy is called for...
@dalehenrich
Copy link
Member Author

At the end of the day the real fix was two-fold. One was to reduce the timeout ... 20s seems to be about right while 500ms can be too short ... Two was retry when a timeout caused a failure ... the retry on timeout was the key fix since that bit of logic is absolutely required for the internet ... especially in the last couple of days ...

Putting the patch into GsDevKit/gsUpgrader#14 so that the proper logic can be in force when starting an install ... should be enough to get to the point where the proper patch isn installed ...

dalehenrich added a commit to GsDevKit/gsUpgrader that referenced this issue Mar 24, 2015
dalehenrich added a commit to GsDevKit/gsUpgrader that referenced this issue Mar 24, 2015
… ... in fact it apears that a single 500 ms wait _without retries_ is not sufficient, so bugfix needs to change as well
dalehenrich added a commit to glassdb/glass that referenced this issue Mar 24, 2015
…swd:do: needs to choreograph the HTTPSocket>>getResponseUpTo:ignoring: retries, since the best response is retry with a new connection and HTTPSocket cannot and should not try to do that itself
dalehenrich added a commit to glassdb/glass that referenced this issue Mar 24, 2015
@dalehenrich
Copy link
Member Author

clean build

dalehenrich added a commit to glassdb/glass that referenced this issue Apr 10, 2023
…graphy load issue resolved

Issue GsDevKit#60: fix NeoJSON specification and add 'REST' to 'CI' group ... defer reference to GsDevKit/NeoJSON project until travis tests have been enabled ...
dalehenrich added a commit to glassdb/glass that referenced this issue Apr 10, 2023
…ST tests were not all passing (Issue GsDevKit#63 records fact that ZnExampleStorageRestServerDelegateTest>>testQuery needs GsDevKit support)
dalehenrich added a commit to glassdb/glass that referenced this issue Apr 10, 2023
dalehenrich added a commit to glassdb/glass that referenced this issue Apr 10, 2023
fix Issue GsDevKit#60.
updated REST tests from @HeSe
WebSocket packages from @HeSe, but still issues with loading
Cryptography package (Issue GsDevKit#58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants