Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seaside-Gettext-Core-WillemVanDenEnde.11 and Seaside-Gettext-Examples-pmm.5 may not be loading correctly #43

Closed
dalehenrich opened this issue Sep 12, 2014 · 16 comments

Comments

@dalehenrich
Copy link
Member

see the warnings here and here

The tests all pass but it sure seems to me that there might be issues with Gettext...

@dalehenrich
Copy link
Member Author

This shows up when you load ALL for Seaside31 ... so perhaps Gettext is unintentionally being loaded?

@jbrichau
Copy link
Member

Test coverage for get text is indeed zero (known issue). Strange that it's getting loaded before Seaside.

@jbrichau jbrichau mentioned this issue Sep 14, 2014
@jbrichau
Copy link
Member

Strangely, the Gettext package does not get loaded... though it's part of the CI group... here

@dalehenrich
Copy link
Member Author

Ah yes .. I didn't see the gettext come in unless I did a load of 'ALL' and
just assumed that it was not part of the CI group ... if it's supposed to
be I can take a look ...

On Mon, Sep 15, 2014 at 11:39 AM, Johan Brichau notifications@github.com
wrote:

Strangely, the Gettext package does not get loaded... though it's part of
the CI group...


Reply to this email directly or view it on GitHub
#43 (comment).

@jbrichau
Copy link
Member

It was not, but I added it yesterday to debug the problems.
One issue I fixed already (#Core does not exist in ConfigurationOfGettext), but now I just don’t see it getting loaded, but it should be because I added it to the CI group.

Unless I overlook something stupid in the BaselineOfSeaside3, which I probably do :)

On 15 Sep 2014, at 20:46, Dale Henrichs notifications@github.com wrote:

Ah yes .. I didn't see the gettext come in unless I did a load of 'ALL' and
just assumed that it was not part of the CI group ... if it's supposed to
be I can take a look ...

On Mon, Sep 15, 2014 at 11:39 AM, Johan Brichau notifications@github.com
wrote:

Strangely, the Gettext package does not get loaded... though it's part of
the CI group...


Reply to this email directly or view it on GitHub
#43 (comment).


Reply to this email directly or view it on GitHub.

@dalehenrich
Copy link
Member Author

I'm working in this area, so ping me if you are still seeing problems when
you need to stop for the day and I'll pick up and see what I can figure out
...

On Mon, Sep 15, 2014 at 11:49 AM, Johan Brichau notifications@github.com
wrote:

It was not, but I added it yesterday to debug the problems.
One issue I fixed already (#Core does not exist in
ConfigurationOfGettext), but now I just don’t see it getting loaded, but it
should be because I added it to the CI group.

Unless I overlook something stupid in the BaselineOfSeaside3, which I
probably do :)

On 15 Sep 2014, at 20:46, Dale Henrichs notifications@github.com wrote:

Ah yes .. I didn't see the gettext come in unless I did a load of 'ALL'
and
just assumed that it was not part of the CI group ... if it's supposed
to
be I can take a look ...

On Mon, Sep 15, 2014 at 11:39 AM, Johan Brichau <
notifications@github.com>
wrote:

Strangely, the Gettext package does not get loaded... though it's part
of
the CI group...


Reply to this email directly or view it on GitHub
#43 (comment).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#43 (comment).

@jbrichau
Copy link
Member

don't worry, I'll take a look tomorrow again (too tired now)

@dalehenrich
Copy link
Member Author

just say the word:) and I'll take a peek

On Mon, Sep 15, 2014 at 12:44 PM, Johan Brichau notifications@github.com
wrote:

don't worry, I'll take a look tomorrow again (too tired now)


Reply to this email directly or view it on GitHub
#43 (comment).

@jbrichau
Copy link
Member

I don't see why Metacello is not honouring the requires statement:

package: 'Seaside-Gettext-Core' with: [ spec requires: #('Core' 'Gettext-Project') ];

@dalehenrich
Copy link
Member Author

I can take a look if you're ready to pass it off:)

On Sat, Sep 20, 2014 at 12:36 PM, Johan Brichau notifications@github.com
wrote:

I don't see why Metacello is not honouring the requires statement:

package: 'Seaside-Gettext-Core' with: [ spec requires: #('Core' 'Gettext-Project') ];


Reply to this email directly or view it on GitHub
#43 (comment).

@jbrichau
Copy link
Member

It's all yours. I managed to see (and fix) why Gettext was not being loaded with the CI group but this one is puzzling me.

@dalehenrich
Copy link
Member Author

Regarding the mysterious loads: Turns out that this was a configuration error that I fixed with the ConfigurationOfSeaside3-dkh.205 checkin ... so previously loads from the ConfigurationOfSeaside3 would include Gettext and SeasideRest beecause they were defined in a #common section in the config ... I changed the sections to #squeakCommon and everthings jake ... I think that the 310 baselines are still exposed quite a bit, but they are old and I don't want to upset the spple cart there...

@dalehenrich
Copy link
Member Author

The problem is that the dependency is upon a group ('Core') and not a package or project ('Seaside-Core') ..... Now I've got to dive into things and try to figure out if this was ever supposed to work:)

@jbrichau
Copy link
Member

jbrichau commented Oct 2, 2014

aha. Thanks for fixing that.
and yes, would be great to be able to express dependency on an entire group :)

@dalehenrich
Copy link
Member Author

Made the dependency change while working on Issue #48 in commit

dalehenrich added a commit that referenced this issue Dec 14, 2014
…client...

Issue #43: Seaside-Gettext-Core actually depends upon Seaside-Session as well, so restore dependence upon 'Core', as originally spec'ed ... available as part of issue_54 branch
@dalehenrich
Copy link
Member Author

With the previous commit, restored dependency upon 'Core' as originally specified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants