-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seaside-Gettext-Core-WillemVanDenEnde.11 and Seaside-Gettext-Examples-pmm.5 may not be loading correctly #43
Comments
This shows up when you load ALL for Seaside31 ... so perhaps Gettext is unintentionally being loaded? |
Test coverage for get text is indeed zero (known issue). Strange that it's getting loaded before Seaside. |
Strangely, the Gettext package does not get loaded... though it's part of the CI group... here |
Ah yes .. I didn't see the gettext come in unless I did a load of 'ALL' and On Mon, Sep 15, 2014 at 11:39 AM, Johan Brichau notifications@github.com
|
It was not, but I added it yesterday to debug the problems. Unless I overlook something stupid in the BaselineOfSeaside3, which I probably do :) On 15 Sep 2014, at 20:46, Dale Henrichs notifications@github.com wrote:
|
I'm working in this area, so ping me if you are still seeing problems when On Mon, Sep 15, 2014 at 11:49 AM, Johan Brichau notifications@github.com
|
don't worry, I'll take a look tomorrow again (too tired now) |
just say the word:) and I'll take a peek On Mon, Sep 15, 2014 at 12:44 PM, Johan Brichau notifications@github.com
|
I don't see why Metacello is not honouring the requires statement: package: 'Seaside-Gettext-Core' with: [ spec requires: #('Core' 'Gettext-Project') ]; |
I can take a look if you're ready to pass it off:) On Sat, Sep 20, 2014 at 12:36 PM, Johan Brichau notifications@github.com
|
It's all yours. I managed to see (and fix) why Gettext was not being loaded with the CI group but this one is puzzling me. |
Regarding the mysterious loads: Turns out that this was a configuration error that I fixed with the ConfigurationOfSeaside3-dkh.205 checkin ... so previously loads from the ConfigurationOfSeaside3 would include Gettext and SeasideRest beecause they were defined in a #common section in the config ... I changed the sections to #squeakCommon and everthings jake ... I think that the 310 baselines are still exposed quite a bit, but they are old and I don't want to upset the spple cart there... |
The problem is that the dependency is upon a group ('Core') and not a package or project ('Seaside-Core') ..... Now I've got to dive into things and try to figure out if this was ever supposed to work:) |
aha. Thanks for fixing that. |
…client... Issue #43: Seaside-Gettext-Core actually depends upon Seaside-Session as well, so restore dependence upon 'Core', as originally spec'ed ... available as part of issue_54 branch
With the previous commit, restored dependency upon 'Core' as originally specified |
see the warnings here and here
The tests all pass but it sure seems to me that there might be issues with Gettext...
The text was updated successfully, but these errors were encountered: