WAExternalFileLibraryTest>>#testAsAbsoluteUrlRelativeTo & WAExternalFileLibraryTest>>#testPathForRequest failing in internal GemStone tests

[dalehenrich]

GRGemsStonePlatform>>defaultDirectoryPathString is not defined and internally we get subclassResponsibility error ... why aren't we getting this failure in Travis tests?

[dalehenrich]

@jbrichau, the travis tests are failing and it looks like it's due to your recent commit of Seaside-FileSystem-JohanBrichau.28. It looks like you included several GRPharoPlatform methods:

GRPharoPlatform>>defaultDirectoryPathString
GRPharoPlatform>>fileNameFor:
GRPharoPlatform>>isDirectory:

and we're missing the GemStone versions of those methods...

Plus it looks like there is no test for WAExternalFileLibrary>>processContext:, which sends isDirectory: and no test for WAExternalFileLibrary>>directory which sends fileNameFor:

I think that we need to have a configuration for the FileSystem stuff, since as it is in the BaselineOfSeaside3, we pick up the latest versions of these files as we've possibly broken a bunch of GemStone Seaside installations out there...

[jbrichau]

Hm... This is actually in Seaside 3.2 and I did not change Grease on github yet. So I should check why this already has this impact and fix it today

Sent from my iPad

On 08 Oct 2014, at 02:53, Dale Henrichs notifications@github.com wrote:

@jbrichau, the travis tests are failing and it looks like it's due to your recent commit of Seaside-FileSystem-JohanBrichau.28. It looks like you included several GRPharoPlatform methods:

GRPharoPlatform>>defaultDirectoryPathString
GRPharoPlatform>>fileNameFor:
GRPharoPlatform>>isDirectory:
and we're missing the GemStone versions of those methods...

Plus it looks like there is no test for WAExternalFileLibrary>>processContext:, which sends isDirectory: and no test for WAExternalFileLibrary>>directory which sends fileNameFor:

I think that we need to have a configuration for the FileSystem stuff, since as it is in the BaselineOfSeaside3, we pick up the latest versions of these files as we've possibly broken a bunch of GemStone Seaside installations out there...

—
Reply to this email directly or view it on GitHub.

[dalehenrich]

I think it's happening because we aren't specifying package vresions for
these files in our github baseline but we're pulling the packages from
smalltalkhub so we're getting the latest package there ...

I changed the gettext project to use the packages in the seaside repo and
presumably we could move the FileSystem packages into the github repo as
well ... since the dependencies upon Sport are gone ...

On Tue, Oct 7, 2014 at 10:03 PM, Johan Brichau notifications@github.com
wrote:

Hm... This is actually in Seaside 3.2 and I did not change Grease on
github yet. So I should check why this already has this impact and fix it
today

Sent from my iPad

On 08 Oct 2014, at 02:53, Dale Henrichs notifications@github.com
wrote:

@jbrichau, the travis tests are failing and it looks like it's due to
your recent commit of Seaside-FileSystem-JohanBrichau.28. It looks like you
included several GRPharoPlatform methods:

GRPharoPlatform>>defaultDirectoryPathString
GRPharoPlatform>>fileNameFor:
GRPharoPlatform>>isDirectory:
and we're missing the GemStone versions of those methods...

Plus it looks like there is no test for
WAExternalFileLibrary>>processContext:, which sends isDirectory: and no
test for WAExternalFileLibrary>>directory which sends fileNameFor:

I think that we need to have a configuration for the FileSystem stuff,
since as it is in the BaselineOfSeaside3, we pick up the latest versions of
these files as we've possibly broken a bunch of GemStone Seaside
installations out there...

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#48 (comment).

[jbrichau]

Thx for the info.
I did not have a chance to devote some attention to this but I will in an hour or so.

On 08 Oct 2014, at 18:30, Dale Henrichs notifications@github.com wrote:

I think it's happening because we aren't specifying package vresions for
these files in our github baseline but we're pulling the packages from
smalltalkhub so we're getting the latest package there ...

I changed the gettext project to use the packages in the seaside repo and
presumably we could move the FileSystem packages into the github repo as
well ... since the dependencies upon Sport are gone ...

On Tue, Oct 7, 2014 at 10:03 PM, Johan Brichau notifications@github.com
wrote:

Hm... This is actually in Seaside 3.2 and I did not change Grease on
github yet. So I should check why this already has this impact and fix it
today

Sent from my iPad

On 08 Oct 2014, at 02:53, Dale Henrichs notifications@github.com
wrote:

@jbrichau, the travis tests are failing and it looks like it's due to
your recent commit of Seaside-FileSystem-JohanBrichau.28. It looks like you
included several GRPharoPlatform methods:

GRPharoPlatform>>defaultDirectoryPathString
GRPharoPlatform>>fileNameFor:
GRPharoPlatform>>isDirectory:
and we're missing the GemStone versions of those methods...

Plus it looks like there is no test for
WAExternalFileLibrary>>processContext:, which sends isDirectory: and no
test for WAExternalFileLibrary>>directory which sends fileNameFor:

I think that we need to have a configuration for the FileSystem stuff,
since as it is in the BaselineOfSeaside3, we pick up the latest versions of
these files as we've possibly broken a bunch of GemStone Seaside
installations out there...

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#48 (comment).

—
Reply to this email directly or view it on GitHub.

[dalehenrich]

Yeah, it looks like we'll need some platform specific packages in the github repo along with moving some methods from the grease gemstone package into the filesystem gemstone package

[jbrichau]

I will just grab the FileSystem packages that go with the 3.1 release of Seaside. The new versions will go into the 3.2 version, which has no Gemstone version yet. I just did not realize the baseline was loading the latest versions from smalltalkhub, which is not a good practice, so eliminated that.

[jbrichau]

The missing tests are something to be fixed in Seaside 3.2 imho. So I propose to close and I reported a bug against Seaside: https://code.google.com/p/seaside/issues/detail?id=832

[dalehenrich]

sounds good

On Wed, Oct 8, 2014 at 11:38 AM, Johan Brichau notifications@github.com
wrote:

The missing tests are something to be fixed in Seaside 3.2 imho. So I
propose to close and I reported a bug against Seaside:
https://code.google.com/p/seaside/issues/detail?id=832

—
Reply to this email directly or view it on GitHub
#48 (comment).