Do not hardcode paths

[jtojnar]

I am trying to package Guake 3 on NixOS but Guake hardcodes some paths, making it incompatible with Nix.

• Checking if theme exists should respect XDG_DATA_DIRS. This is how we fixed it in GNOME Tweaks. => Follow up Use XDG_DATA_DIRS to search gtk themes #1249
• Instead of executing dconf, appropriate Gio.Settings call should be made. => Follow up Replace call of dconf by Gio.Settings #1250
• LOCALE_DIR should be configurable using make flags.
• Same for other directories so that Arch need not patch it.
• pixmaps and GtkBuilder files should be actually installed by the Makefile.
• Makefile should set --prefix flag for setup.py install

Downstream PR: NixOS/nixpkgs#38642

[gsemet]

thanks for your report. I'll do my best to update guake this week to make it distribution friendly !

[jtojnar]

You might actually want to use the standard names (i.e. lowercase prefix, *dir), something like this:

# Common prefix for installation directories.
# NOTE: This directory must exist when you start the install.
prefix = /usr/local
datarootdir = $(prefix)/share
datadir = $(datarootdir)
exec_prefix = $(prefix)
bindir = $(exec_prefix)/bin
localedir = $(datarootdir)/locale
gsettingsschemadir=$(datarootdir)/share/glib-2.0/schemas
…

I also think INSTALL_ROOT is commonly called DESTDIR.

cc @aichingm