Endless transparency keyboard shortcut toggles

[thardev]

Hello! I've noticed that when you use the keyboard shorcut to increase/decrease transparency if you keep pushing the key combination, the transparency goes to the higher level but, as I see in the code the transparency function that controls the level, doesn't have a limit, so you can increase it endless and the result is that when you want to decrease it doesn't works as expected...

Code:

guake/src/guake/guake_app.py

Lines 1117 to 1129 in 589131a

	def accel_increase_transparency(self, *args):
	"""Callback to increase transparency.
	"""
	transparency = self.client.get_int(KEY('/style/background/transparency'))
	self.client.set_int(KEY('/style/background/transparency'), int(transparency) + 2)
	return True
	def accel_decrease_transparency(self, *args):
	"""Callback to decrease transparency.
	"""
	transparency = self.client.get_int(KEY('/style/background/transparency'))
	self.client.set_int(KEY('/style/background/transparency'), int(transparency) - 2)
	return True

PS: It's a bit hard to explain this issue because I cannot show it with screenshots, GIF's, etc 😫

[gsemet]

i understand good point !