-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add hide tab bar when only one tab option #1873
Conversation
Would you like to add unit test (at least to test preference) for this? |
Pushed changes to address review, can do test cases later |
a real quick test case added in |
Consider to consist the tag name and function name, maybe |
Alright I renamed it to be a little closer to how I called it in the option. |
Also tied hide tab bar to some related menu options.
Remove translation section because irrelevant and breaks checks and I apparently don't know how to format it
Can you tell me if this PR is still relevant? |
Still works as intended, there might be a merge conflict in prefs.glade because other things that change preferences layout have been merged since this was created but I'm otherwise a go to have this finally merged if there's no merge conflict. |
LGTM, #1896 can wait on this. |
Also tied hide tab bar to some related menu options.
Resolves #924 and potentially other related issues