-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Make guake use the system default theme #1874
Conversation
For this on I let you fix the pipeline and switch back to norminal review, merge |
Maybe the travis thing is just there from before, still not going away. I'll fix something on the issues list and see if a new pr still has it. |
ok, found it :D |
Seems some black format issue: https://github.com/Guake/guake/pull/1874/checks?check_run_id=3532130826#step:5:414
|
|
I've put a separate PR for coding style: #1880 |
Oh whoops, left it while it was running because I thought it was going to pass. Well, ran black on this and the other one now, and I'll stick around to check that it passes this time. Was just some whitespace thing though according to the diff |
Oh, is there some nonsense I have to do with regenerating the reno file? I'll get to figuring that out |
Some bizarre nonsense where |
Alright, figured it out, I just messed up formatting on the slug file |
Can you rebase and check if the coding style may changed by black? |
Changes in one file, fixed up now. |
And merged as well ! |
Detect system theme by default like other gtk programs. Some misc setup/cleanup changes in the fork as well.