Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Make guake use the system default theme #1874

Merged
merged 4 commits into from
Sep 10, 2021
Merged

feat:Make guake use the system default theme #1874

merged 4 commits into from
Sep 10, 2021

Conversation

Davidy22
Copy link
Collaborator

Detect system theme by default like other gtk programs. Some misc setup/cleanup changes in the fork as well.

@gsemet
Copy link
Member

gsemet commented Sep 7, 2021

For this on I let you fix the pipeline and switch back to norminal review, merge

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Sep 7, 2021

Maybe the travis thing is just there from before, still not going away. I'll fix something on the issues list and see if a new pr still has it.

@gsemet
Copy link
Member

gsemet commented Sep 7, 2021

ok, found it :D

@mlouielu
Copy link
Collaborator

mlouielu commented Sep 7, 2021

Seems some black format issue:

https://github.com/Guake/guake/pull/1874/checks?check_run_id=3532130826#step:5:414

would reformat /home/runner/work/guake/guake/guake/prefs.py
Oh no! 💥 💔 💥
1 file would be reformatted, 32 files would be left unchanged.

@gsemet
Copy link
Member

gsemet commented Sep 7, 2021

make style is your friend.

@mlouielu
Copy link
Collaborator

mlouielu commented Sep 7, 2021

I've put a separate PR for coding style: #1880

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Sep 7, 2021

Oh whoops, left it while it was running because I thought it was going to pass. Well, ran black on this and the other one now, and I'll stick around to check that it passes this time. Was just some whitespace thing though according to the diff

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Sep 7, 2021

Oh, is there some nonsense I have to do with regenerating the reno file? I'll get to figuring that out

@Davidy22 Davidy22 changed the title Make guake use the system default theme feat:Make guake use the system default theme Sep 7, 2021
@Davidy22
Copy link
Collaborator Author

Davidy22 commented Sep 7, 2021

Some bizarre nonsense where python setup.py sdist works before I commit a slug file but breaks after. I'll figure this out eventually

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Sep 8, 2021

Alright, figured it out, I just messed up formatting on the slug file

@mlouielu mlouielu self-requested a review September 9, 2021 01:39
@mlouielu
Copy link
Collaborator

mlouielu commented Sep 9, 2021

Can you rebase and check if the coding style may changed by black?

@Davidy22
Copy link
Collaborator Author

Davidy22 commented Sep 9, 2021

Changes in one file, fixed up now.

@gsemet
Copy link
Member

gsemet commented Sep 10, 2021

And merged as well !

@gsemet gsemet merged commit 4f7f95a into Guake:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants