Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n fixes and updated Polish translation #519

Merged
merged 7 commits into from
May 4, 2015
Merged

I18n fixes and updated Polish translation #519

merged 7 commits into from
May 4, 2015

Conversation

piotrdrag
Copy link
Contributor

No description provided.

This one file was somehow missed.
Just cosmetics.
There is no fr_FR translation, only fr. Also sorts translations.
Until there is proper support for .desktop files internationalization.

#!/bin/bash

sleep 5 # it is advised to wait a bit guake has been successfully started
sleep 5 # it is advised to wait a bit after Guake has been successfully started
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sleep is before we start guake no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace it with "before" in a subsequent commit - I'm new to github and I don't know how to change my pull request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a new commit to the branch you added these commits, it will be picked up automatically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


#!/bin/bash

sleep 5 # it is advised to wait a bit guake has been successfully started
sleep 5 # it is advised to wait a bit before Guake has been successfully started
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tempo was a workaround for the pbl with globalhotkey not able to capture some keys when the gnome desktop is being started. There is probably some keyboard reconfiguration going on when the desktop is started... So this is a quick and dirty way of avoid such issue...

@gsemet
Copy link
Member

gsemet commented May 4, 2015

Thanks guys!

gsemet added a commit that referenced this pull request May 4, 2015
I18n fixes and updated Polish translation
@gsemet gsemet merged commit ce3283c into Guake:master May 4, 2015
@gsemet gsemet added this to the 0.7.1 milestone May 4, 2015
gsemet added a commit that referenced this pull request Jan 30, 2017
I18n fixes and updated Polish translation
gsemet added a commit that referenced this pull request Jan 30, 2017
I18n fixes and updated Polish translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants