Add legend transparency to theme_transparent #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Continue to review full report at Codecov.
|
|
thanks! I add your name in author list as contributor, see https://github.com/GuangchuangYu/ggtree/blob/master/DESCRIPTION. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if a legend is added to the plot with
the plot won't have a fully transparent background because of the legend. This commit proposes a fix for that.
You may argue that this is not the job of this theme. If users add a legend, they can as well tweak the theme for their own needs.
However, I think having a fully transparent theme falls within the expectation of the user when using this theme.