fix(bc-footer): Fix footer issues #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermegpessoa
changed the title
dewen
approved these changes
Mar 25, 2022
Guilherme-Almeida-Zeni
added a commit
that referenced
this pull request
Mar 30, 2022
* feature(bc-footer): Add Brand.com Footer * feature(bc-footer): Final Styles Adjustments * feature(bc-footer): Copyright as RTE, Add TODO On Social Links AND Removed Unnecessary FlowHoc * feature(bc-footer): Move Sepator Styles To Its Own Token * feature(bc-footer): Rename GlobalFooter To Footer * feature(bc-footer): Address PR Feedback - Batch 1 * Reorganize menu. (#7) * Reorganize menu. * Remove redundant footer menu styling. * Add submenu titles. * Remove duplication in MenuTitleClean * Fix lint * Add canvasx token docs. * feature(bc-footer): Fix doc typo Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> * feature(bc-footer): Fix doc typo Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com> Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> * feature(bc-footer): Update Footer Menu Data * feature(bc-footer): Update Package.Lock * feature(bc-footer): Remove Console Log From Menu Separator * feature(bc-footer): Improve Footer Structure For Later Static Implementation * feature(bc-footer): Add Todo Comments * feature(bc-footer): Rename SiteHeader And SiteFooter To Header And Footer * feature(bc-footer): Add Cx Navigation To TSConfig * feature(bc-footer): Rename Remaining SiteHeader And SiteFooter To Header And Footer * feature(bc-footer): Adjust Layout After Updates * Token site constrains (#8) * feature(bc-footer): Add Footer Slots Wrappers * feature(bc-footer): Refactor Footer Copyright RichText * feature(bc-footer): Update Footer And Copyright Keys * feature(bc-footer): Add Footer Page Example * feature(bc-footer): Feedback Fixes - Batch 2 * feature(bc-footer): Update Cx Navigation Package Version * fix(bc-footer): Fix Footer Issues (#10) * bugfix(bc-footer): Fix Footer Issues * Remove top margin from in footnote * Add uppercase to submenu items * Removing unused imports * bugfix(bc-footer): Fix comments on PR * bugfix(bc-footer): Fix link issues Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com> * feature(bc-footer): Fix issues after main branch update * fix(bc-footer): Fix footer issues (#13) * fix(bc-footer): Fix padding issues * fix(bc-footer) Fix padding values * fix(bc-footer): Fix padding issues * feature(bc-footer): Update Footer Content * bugfix(bc-footer): Fix Footer Menu Issues Issues (#16) * bugfix(bc-footer): Fix Footer Menu Accessibility Issues * bugfix(bc-footer): Add External And Download Icons To Menu Title Links Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> * bugfix(bc-footer): Fix Mobile Margins Between Submenus (#17) Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> Co-authored-by: wodenx <wodenx@gmail.com> Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com> Co-authored-by: guilhermegpessoa <48322825+guilhermegpessoa@users.noreply.github.com>
Guilherme-Almeida-Zeni
added a commit
that referenced
this pull request
Apr 12, 2022
* feature(bc-footer): Add Brand.com Footer * feature(bc-footer): Final Styles Adjustments * feature(bc-footer): Copyright as RTE, Add TODO On Social Links AND Removed Unnecessary FlowHoc * feature(bc-footer): Move Sepator Styles To Its Own Token * feature(bc-footer): Rename GlobalFooter To Footer * feature(bc-footer): Address PR Feedback - Batch 1 * Reorganize menu. (#7) * Reorganize menu. * Remove redundant footer menu styling. * Add submenu titles. * Remove duplication in MenuTitleClean * Fix lint * Add canvasx token docs. * feature(bc-footer): Fix doc typo Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> * feature(bc-footer): Fix doc typo Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com> Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> * feature(bc-footer): Update Footer Menu Data * feature(bc-footer): Update Package.Lock * feature(bc-footer): Remove Console Log From Menu Separator * feature(bc-footer): Improve Footer Structure For Later Static Implementation * feature(bc-footer): Add Todo Comments * feature(bc-footer): Rename SiteHeader And SiteFooter To Header And Footer * feature(bc-footer): Add Cx Navigation To TSConfig * feature(bc-footer): Rename Remaining SiteHeader And SiteFooter To Header And Footer * feature(bc-footer): Adjust Layout After Updates * Token site constrains (#8) * feature(bc-footer): Add Footer Slots Wrappers * feature(bc-footer): Refactor Footer Copyright RichText * feature(bc-footer): Update Footer And Copyright Keys * feature(bc-footer): Add Footer Page Example * feature(bc-footer): Feedback Fixes - Batch 2 * feature(bc-footer): Update Cx Navigation Package Version * fix(bc-footer): Fix Footer Issues (#10) * bugfix(bc-footer): Fix Footer Issues * Remove top margin from in footnote * Add uppercase to submenu items * Removing unused imports * bugfix(bc-footer): Fix comments on PR * bugfix(bc-footer): Fix link issues Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com> * feature(bc-footer): Fix issues after main branch update * feature(cx-navigation): Add CX Navigation * feature(cx-navigation): Add WTB Button Placeholder * feature(navigation): Update Content For Better Styling * feature(bc-navigation): Style Burger Menu For Mobile And Tablet * feature(bc-navigation): Fix Where To Buy Components Name * feature(bc-navigation): Fix Issues Due To Conflict Resolution * feature(bc-navigation): Reupdate Header After Conflicts Resolution * feature(bc-navigation): Add Navigation Desktop Style * fix(bc-footer): Fix footer issues (#13) * fix(bc-footer): Fix padding issues * fix(bc-footer) Fix padding values * fix(bc-footer): Fix padding issues * feature(navigation): Remove Unused Module Import * feature(bc-navigation): Add NoWrap To Menus * feature(bc-navigation): Address Feedback * feature(bc-footer): Update Footer Content * bugfix(bc-footer): Fix Footer Menu Issues Issues (#16) * bugfix(bc-footer): Fix Footer Menu Accessibility Issues * bugfix(bc-footer): Add External And Download Icons To Menu Title Links Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> * Feature/bc navigation (#19) * Replace WTB with styled link * Fix lint * Feature/cx navigation toggler (#20) * Replace WTB with styled link * Fix lint * Remove burger menu toggler component. Co-authored-by: Guilherme Almeida Zeni <gzeni@ciandt.com> * feature(bc-navigation): Last Updates * feature(bc-navigation): Remove Old Index File * feature(bc-navigation): Update Header Constrains To Be In Container Component * feature(bc-navigation): Fix Header BG After Main Updates * docs(bc-navigation): BC Navigation Docs * bugfix(bc-navigation): Fix Navigation Issues (#21) Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> * feature(bc-navigation): Fix Submenu Paddings * bugfix(bc-navigation): Fix Safari Burger Menu Issue And Add ID To Header (#22) Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> * feature(bc-navigation): Fix Safari Issues (#24) Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> * feature(cx-navigation): Update Tailwind Configs After Merge Conflicts Resolution * feature(bc-navigation): Fix Top Nav Menu Style Co-authored-by: Guilherme Zeni <gzeni@its.jnj.com> Co-authored-by: wodenx <wodenx@gmail.com> Co-authored-by: hvanyo <58534559+hvanyo@users.noreply.github.com> Co-authored-by: guilhermegpessoa <guilherme.gpessoa@hotmail.com> Co-authored-by: guilhermegpessoa <48322825+guilhermegpessoa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR contains some fixes for some issues reported on feature/bc-footer:
Test Instructions
Related Issues