Pull new commits from forked repository #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctory (#573) Due to a race condition and subscribing/unsubscribing from different threads it may have happened that unregistering was made before registering finished.
# Conflicts: # gradle.properties
The issue was hidden by a try/catch. This should not happen when using Schedulers.trampoline() to subscribe/unsubscribe.
…574) Seems unnecessary
The access to the callback is available through `RxBleConnection.observeConnectionParametersUpdates()` Additionally it is possible to get it in `RxBleCustomOperation`: - `RxBleGattCallback.getConnectionParametersUpdates()` - `RxBleGattCallback.setHiddenGattCallback(HiddenBluetoothGattCallback)` The callback is not used for completing `RxBleConnection.requestConnectionPriority()`. It is not possible to universally distinguish which callback is the one that should complete the request. Why? Android OS does change connection parameters on its own at the beginning of the connection to speedup service discovery process. After the discovery parameters are relaxed. If a request is made during this period it is not possible to know which callback is related to the user's request. It is worth noting that making a request early will make it quickly overwritten by the above mentioned process. This is _not_ a part of public Android API and is not guaranteed to be called.
Usually there are a lot of peripherals advertising nearby and it may be considered too spammy.
# Conflicts: # gradle.properties
io.reactivex.rxjava2:rxjava:2.2.7 -> 2.2.8 org.codehaus.groovy:groovy:2.5.6 -> 2.5.7 cglib:cglib-nodep:3.2.10 -> 3.2.12
This reverts commit b3dca6b.
This reverts commit e23018a.
This reverts commit a493671.
It is now possible to set a whitelist of branches that may produce snapshots
Use “true”/“false” and camelCase, remove error return
Only versions named ‘*-SNAPSHOT’ should be released as such.
It is now available on the Wiki regarding RxJava 1 version
Setting a cancelable on an Emitter did run it immediately if it was already disposed. Postponing the setting until after the BroadcastReceiver is registered fixed the issue.
It should now match other Polidea libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.