-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unexpected keyword argument 'size' #3
Comments
This is a known issue because gensim changed their arguments in the word2vec model. See also:
At this point I'm not super enthusiastic about updating the code in this repo for a few reasons:
If you're gearing up for a publication and need a co-author, I could probably find some time to give some real support. In the mean time, I'd suggest checking out some of the follow-up work to GuiltyTargets that use the same ideas, but have a bit more clean and reusable code: |
Charles, thank you very much for the prompt response. I figured out the issue with genesim and a couple of other packages that gat2vec relies on and had to be downgraded in order to use the code 'as is'. My summer intern is trying to use the approach for target prioritization. So I am not sure if we would be ready for a publication any sooner, but that is an encouraging thought. Thanks for offering to help. I'll reach out if we decided to pursue this idea further. Vishal |
Dear Vishal, Thank you for your interest in our work. If you let me know which versions Gat2Vec requires, I can update the documentation. I'd like to add that using Gat2Vec as opposed to DeepWalk increased the performance by 1-2% which could be important depending on how many candidates you are working with. You can address your questions to me in the future as this is primarily my work. We no longer work on this project, but the purpose of making it open source was so that the community could also contribute. Best, |
Dear Özlem, I had the same issue, how can I solve this issue? thank you for your help Best, |
Dear Salvatore, The error is caused by a version mismatch in the gensim library. Originally, one of the parameters to initialize a Word2Vec object was named size, but it changed to vector_size. I now updated the gat2vec library which uses gensim to be compatible with the more recent version of gensim. Please do a clean install (including, and especially for gat2vec) and let me know if it works now. Best, |
Dear Özlem, Thank you for updating the code. I was working in these days on my machine, I uninstalled and reistalled all the libraries and now it looks like it works. However, it may useful for you to know (or if someone else wants to use it) after uninstalling Gat2vec, Guiltytarget and deepwalk and reinstall them, was still giving me errors. The first error is during import guiltytargets, it requires to uninstall and reinstall gensim the second was generated by a deprecated function in gat2vec, in the parser file. the function as_matrix is deprecated and removed in pandas. I present here the correct code that permitted me to solve the error:
There is another error, in the evaluation file of the gat2vec, the iid= False argument is deprecated and removed from scikit-learn, here the updated code:
I did not received other errors and it work smoothly then since I had to slightly modified the code I have a couple to additional questions. a) after running GuiltyTargets with my files it returns the following outputs:
is it correct? b) probes_df is returning a dataframe with 3 columns 0, 1 entrez which I suppose are the probabilities for each entrez gene to be a target (class 1) or not a target (class 0). is it correct? did you use on the probabilities argmax function to consider it a target or not? c) did you use the probability to rank the target? best, Salvatore |
Dear Salvatore, Thank you for your input. Would you like to do a pull request so your contribution to the repository is more visible? Regarding your questions: For the rest of your questions, I will need to double check the output files, then I will get back to you. I am closing this issue, since it's no longer about the original question. Here are the new issues: Best, |
Update deprecated function based on GuiltyTargets/guiltytargets#3 (comment)
Update based on GuiltyTargets/guiltytargets#3 (comment)
Hi Charles,
First, I'd like to thank you for contributing this interesting work and sharing the code with the community. I am trying to run the GuiltyTargets pipeline using example data shared in the previous #2 issue (of course, after fixing the issues with the data files). To do this, I created a condo env and installed all the packages as suggested, but ran into the below issue. I would really appreciate your help in fixing this.
I originally wanted to reproduce the results from your paper but since the open targets REST API has been deprecated and replaced by a GraphQL API, I had to directly work with the code from this repo. Also, you mention that some data is provided in supplementary information but I couldn't find any supplementary data in the original publication as well as on bioRxiv. It would be nice to see those tables too.
Thank you,
Vishal
The text was updated successfully, but these errors were encountered: