Refacto: modernizing and optimizing source codebase #256
Conversation
Guts
commented
May 20, 2024
•
Guts
commented
- remove deprecated code raising warnings
- replace dict by models based on dataclasses
- factorize Georeaders using a based-class POO approach
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dicogis/export/to_xlsx.py
Outdated
| f"postgresql://{metadataset.database_connection.user_name}" | ||
| f"@{metadataset.database_connection.host}" | ||
| f":{metadataset.database_connection.port}" | ||
| f"/{metadataset.database_connection.database_name}" |
Check failure
Code scanning / SonarCloud
A secure password should be used when connecting to a database
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
===========================================
+ Coverage 15.68% 26.42% +10.74%
===========================================
Files 34 37 +3
Lines 2856 2539 -317
Branches 296 321 +25
===========================================
+ Hits 448 671 +223
+ Misses 2376 1823 -553
- Partials 32 45 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Guts
changed the title
github-actions
bot
added
documentation
Guts
force-pushed
the
refacto/dataclass-models-instead-of-dict
branch
from
64a421b
to
db6ecd3
Compare
|
Guts
added
enhancement
