Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: plugins downloader #168

Merged
merged 26 commits into from Jan 18, 2023
Merged

Feature: plugins downloader #168

merged 26 commits into from Jan 18, 2023

Conversation

Guts
Copy link
Owner

@Guts Guts commented Jan 16, 2023

This PR add logic to download plugins which are referenced within profile.json files downloaded in QDT working directory.

It does not include:

  • the installation/copy of downloaded plugins
  • the local plugins

@Guts Guts self-assigned this Jan 16, 2023
@Guts Guts marked this pull request as draft January 16, 2023 10:27
@github-actions github-actions bot added the jobs Scenarios and jobs label Jan 16, 2023
@Guts Guts marked this pull request as ready for review January 16, 2023 14:27
@github-actions github-actions bot added the quality Tests, project resiliency, etc. label Jan 16, 2023
@Guts Guts added enhancement New feature or request and removed quality Tests, project resiliency, etc. labels Jan 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #168 (dc2b91f) into main (f1a18c9) will decrease coverage by 2.66%.
The diff coverage is 43.29%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   66.49%   63.84%   -2.66%     
==========================================
  Files          31       33       +2     
  Lines        1382     1557     +175     
  Branches      304      342      +38     
==========================================
+ Hits          919      994      +75     
- Misses        392      489      +97     
- Partials       71       74       +3     
Impacted Files Coverage Δ
qgis_deployment_toolbelt/commands/cli_upgrade.py 61.90% <ø> (-0.60%) ⬇️
qgis_deployment_toolbelt/utils/file_downloader.py 30.00% <0.00%> (-2.44%) ⬇️
...ployment_toolbelt/jobs/job_plugins_synchronizer.py 20.38% <20.38%> (ø)
qgis_deployment_toolbelt/constants.py 87.09% <60.00%> (-12.91%) ⬇️
qgis_deployment_toolbelt/plugins/plugin.py 78.57% <78.57%> (ø)
qgis_deployment_toolbelt/profiles/qdt_profile.py 85.43% <80.00%> (-0.43%) ⬇️
...loyment_toolbelt/jobs/job_profiles_synchronizer.py 69.51% <85.71%> (+0.37%) ⬆️
qgis_deployment_toolbelt/cli.py 86.30% <100.00%> (+2.73%) ⬆️
qgis_deployment_toolbelt/jobs/orchestrator.py 84.84% <100.00%> (+0.47%) ⬆️

@github-actions github-actions bot added the quality Tests, project resiliency, etc. label Jan 16, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation tooling Development tooling labels Jan 17, 2023
@Guts Guts changed the title Feature: download and install plugins Feature: plugins downloader Jan 17, 2023
@github-actions github-actions bot added the ci-cd Continuous integration and deployment. label Jan 17, 2023
Copy link
Collaborator

@Ducarouge Ducarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Guts Guts merged commit c7952a6 into main Jan 18, 2023
@Guts Guts deleted the feature/plugins-manager branch January 18, 2023 17:07
@Guts Guts removed ci-cd Continuous integration and deployment. documentation Improvements or additions to documentation labels Jan 18, 2023
Guts added a commit that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jobs Scenarios and jobs quality Tests, project resiliency, etc. tooling Development tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants