Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in evaluation code for processing language. #182

Closed
Silverster98 opened this issue Dec 13, 2023 · 2 comments
Closed

Bugs in evaluation code for processing language. #182

Silverster98 opened this issue Dec 13, 2023 · 2 comments

Comments

@Silverster98
Copy link

Hi,

I have noticed that there may be a bug in your modified evaluation code as follows.

Because the tokens are all padded, if you use len(tokens[bs_i]) to obtain the cap_len, then all sentence lengths will be max_text_len=20 + 2. This will influence the language feature extraction for computing metrics.

And the following code is the original code in HumanML3D, which uses the right token length.

I think this bug may lead to a performance drop in MatchingScore, R-Precision, and so on.

@GuyTevet
Copy link
Owner

That's interesting, can you share the performance of the published model after your bug fix?

GuyTevet added a commit that referenced this issue Jan 31, 2024
Fixed evaluation bug #182 - wrong cap_len calculation
@GuyTevet
Copy link
Owner

Fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants