Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AS Name into Results #62

Closed
m-cameron opened this issue Feb 8, 2023 · 6 comments · Fixed by #181
Closed

Add AS Name into Results #62

m-cameron opened this issue Feb 8, 2023 · 6 comments · Fixed by #181
Labels
enhancement New feature, request, or improvement
Milestone

Comments

@m-cameron
Copy link

Please consider to append ASN information into the results.

You can get the free ASN database from https://lite.ip2location.com/database-asn?lang=en_US

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 8, 2023

This is actually one of the features I will implement in v1.2.0.
Other info that will be added are:

  • MAC addresses
  • rDNS lookups of the remote address

I think I will implement a more detailed page for each of the sniffed connections with these info and their ASN.
If you have other ideas, you can share them without any problem.

@GyulyVGC GyulyVGC added the enhancement New feature, request, or improvement label Feb 8, 2023
@GyulyVGC GyulyVGC added this to the v1.2.0 milestone Feb 8, 2023
@acolombier
Copy link
Contributor

I am very interested in the rDNS feature! Is it something you need help to develop? I'd be happy to give it a go

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 8, 2023

I am very interested in the rDNS feature! Is it something you need help to develop? I'd be happy to give it a go

Thank you very much for your proposal, but I've already tried to implement this feature and it is pretty straightforward thanks to a crate that performs rDNS lookups.

For v1.2.0 I have in mind a larger set of features which will include a new page with a search bar to select a connection to inspect and it's something pretty big and I would like to start it myself.

I will tag you when I'll have something ready (probably in some weeks or a few months) and at that point it'd be amazing to collaborate.

In the meantime, if you really want to help, it'd be nice to write some unit tests for the app (see here for an example of unit tests by @colin99d, to be written at the end of the file with the functions interested by tests).

@acolombier
Copy link
Contributor

That sounds good to me - I will submit some for the enums crate - can see few low hanging fruits in there!

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 8, 2023

That sounds good to me - I will submit some for the enums crate - can see few low hanging fruits in there!

Yep, that should be an easy way to start, thanks very much!

@GyulyVGC GyulyVGC linked a pull request May 16, 2023 that will close this issue
@GyulyVGC
Copy link
Owner

A new release including Autonomous Systems and rDNS lookups has just been published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, request, or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants