chore: add some unit test on notification

[acolombier]

As suggested in the issue #62 , I tasked myself with increasing test coverage and thought I will get started with notifications.

[acolombier]

Since this task requires some minimal refactoring in order to split the code in smaller independent sections, I thought I will start with byte threshold first and wait for your feedback before going ahead and doing all of them.

[GyulyVGC]

Sounds good. Just leave me the refactor tasks. The ideal thing is that you exclusively work inside "tests" modules.

[GyulyVGC]

However, if you already started refactoring keep going.
Just let me know when and where you need it next time.

[GyulyVGC]

At a first read it seems a very good start btw!
It's nice you decided to put that function in the notifications struct, feel free to do the same for the other notifications.
Thanks!

[GyulyVGC]

Favorites Notifications are ok, but could you leave the management for packets and bytes as it was before?
I mean, in your from functions.

[acolombier]

Do you mind pointing out which bits your are referring to? Do you mean the Default trait implementation?

[acolombier]

I have reverted the PacketsNotification and BytesNotification behaviors. I kept the trim addition so there is more edge cases covered, although the UI doesn't let you input anything else.

[GyulyVGC]

Thanks! Once also the formatting will be fixed I'll review it! 👍

[GyulyVGC]

I just fixed the formatting (note that this can be automatically done with cargo fmt) and reviewed the PR and you did a great job.
It's nice you decided to start from the text input fields which are the most vulnerable part of the app.
Tyvm!

[GyulyVGC]

@all-contributors please add @acolombier for test translation

[allcontributors]

@GyulyVGC

I've put up a pull request to add @acolombier! 🎉