Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation korean #128

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Translation korean #128

merged 5 commits into from
Apr 12, 2023

Conversation

DocRAID
Copy link
Contributor

@DocRAID DocRAID commented Apr 11, 2023

No description provided.

@GyulyVGC GyulyVGC added the translation User interface translation label Apr 11, 2023
@GyulyVGC
Copy link
Owner

Thanks πŸŽ‰

Don't worry if you are not seeing Korean characters in the GUI, I just have to manually add them.

})
}

pub fn start_translation(language: Language) -> &'static str {
match language {
Language::EN | Language::DE | Language::RO => "Start!",
Language::EN | Language::DE | Language::RO | Language::KO => "Start!",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct to remain "start"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it because I thought it would look weird if I translate it.
It might be better to leave it as it is :)

@@ -1033,6 +1109,9 @@ pub fn no_notifications_set_translation(language: Language) -> Text<'static> {
Language::RO => "ÎncΔƒ nu aΘ›i activat notificΔƒrile!\n\n\
După ce le veți activa, această pagină va afișa un jurnal al notificărilor dvs\n\n\
Puteți activa notificările din setări:",
Language::KO => "아직 μ•Œλ¦Όμ„ ν™œμ„±ν™”ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€!\n\n\
ν™œμ„±ν™”λ‘œ μ„€μ •ν•˜λ©΄ 이 νŽ˜μ΄μ§€μ— μ•Œλ¦Ό λ‘œκ·Έκ°€ ν‘œμ‹œλ©λ‹ˆλ‹€\n\n\
You can enable notifications from settings:",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed this translation as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opps. I missed the last sentence.
This sentence is "μ„€μ •μ—μ„œ μ•Œλ¦Όμ„ ν™œμ„±ν™”ν•  수 μžˆμŠ΅λ‹ˆλ‹€:" can be translated into

Copy link
Contributor Author

@DocRAID DocRAID left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't meticulous.
Thank you for finding my mistake πŸ˜„

})
}

pub fn start_translation(language: Language) -> &'static str {
match language {
Language::EN | Language::DE | Language::RO => "Start!",
Language::EN | Language::DE | Language::RO | Language::KO => "Start!",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it because I thought it would look weird if I translate it.
It might be better to leave it as it is :)

@@ -1033,6 +1109,9 @@ pub fn no_notifications_set_translation(language: Language) -> Text<'static> {
Language::RO => "ÎncΔƒ nu aΘ›i activat notificΔƒrile!\n\n\
După ce le veți activa, această pagină va afișa un jurnal al notificărilor dvs\n\n\
Puteți activa notificările din setări:",
Language::KO => "아직 μ•Œλ¦Όμ„ ν™œμ„±ν™”ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€!\n\n\
ν™œμ„±ν™”λ‘œ μ„€μ •ν•˜λ©΄ 이 νŽ˜μ΄μ§€μ— μ•Œλ¦Ό λ‘œκ·Έκ°€ ν‘œμ‹œλ©λ‹ˆλ‹€\n\n\
You can enable notifications from settings:",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opps. I missed the last sentence.
This sentence is "μ„€μ •μ—μ„œ μ•Œλ¦Όμ„ ν™œμ„±ν™”ν•  수 μžˆμŠ΅λ‹ˆλ‹€:" can be translated into

@GyulyVGC
Copy link
Owner

Amazing, thank you again πŸŽ‰

@GyulyVGC GyulyVGC merged commit 0a937a1 into GyulyVGC:main Apr 12, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @DocRAID for translation.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @DocRAID! πŸŽ‰

@DocRAID DocRAID deleted the translation-korean branch April 12, 2023 06:29
@GyulyVGC GyulyVGC added this to the v1.1.4 milestone Apr 15, 2023
GyulyVGC added a commit that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation User interface translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants