Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Greek translation #160

Merged
merged 7 commits into from
Apr 21, 2023
Merged

Added Greek translation #160

merged 7 commits into from
Apr 21, 2023

Conversation

abousis
Copy link
Contributor

@abousis abousis commented Apr 21, 2023

Added Greek translation, although Greek letters do not appear at all. I suppose it's the font.

@GyulyVGC
Copy link
Owner

Yep, it's a problem of the font.
I'll check if the full font file contains greek characters and I'll let you know.
Thanks!

@GyulyVGC
Copy link
Owner

I fixed the font problem but I noticed that in some points some greek sentences seems too long and they go on a new line.
For the first picture, could you try using a shorter sentence to convey the same meaning?
For the second picture, I'll try to do something myself.
(It's weird what's happening because in the first case, for example, the Turkish sentence is longer but it displays without problem in the same amount of space)

Screenshot 2023-04-21 at 18 42 51
Screenshot 2023-04-21 at 18 42 42

@abousis
Copy link
Contributor Author

abousis commented Apr 21, 2023

Thank you for the swift response. Checking, and I will revert with an update.

@abousis
Copy link
Contributor Author

abousis commented Apr 21, 2023

I've rewritten the sentence in various ways, it seemed to me character "Θ" was causing this, but it was strange in any case. Also there are longer sentences in Greek, so I suppose it has to do with the font and this specific character.
It seems it's displayed properly now.

screenshot_20230421_212226

screenshot_20230421_212239

@GyulyVGC
Copy link
Owner

Thanks.
I'm wondering why you are seeing those black rectangles instead of the palettes pictures...
Which system are you using? Can you correctly see the country flags?

@abousis
Copy link
Contributor Author

abousis commented Apr 21, 2023

I use Arch Linux. This is on the main branch, if I build the application using the glow-renderer branch as you suggested in README.md, then everything is displayed properly.

screenshot_20230421_230043

screenshot_20230421_230243

@@ -1212,7 +1212,7 @@ pub fn threshold_translation(language: Language) -> String {
Language::TR => "Eşik: ".to_string(),
Language::RU => "Порог: ".to_string(),
Language::PT => "Limite: ".to_string(),
Language::EL => "Όριο: ".to_string(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced this character with its lowercase version and the problem of the second picture I sent you before is now solved

@GyulyVGC
Copy link
Owner

If you can confirm everything is now ok, I'll proceed merging the PR

@abousis
Copy link
Contributor Author

abousis commented Apr 21, 2023

Seems ok, you can proceed.

@GyulyVGC GyulyVGC merged commit 59a9db6 into GyulyVGC:main Apr 21, 2023
@GyulyVGC
Copy link
Owner

@all-contributors please add @abousis for translation.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @abousis! 🎉

GyulyVGC added a commit that referenced this pull request May 7, 2023
Added Greek translation
@GyulyVGC GyulyVGC added this to the v1.2.0 milestone May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation User interface translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants