Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated build and packaging #180

Merged
merged 26 commits into from
May 16, 2023
Merged

Automated build and packaging #180

merged 26 commits into from
May 16, 2023

Conversation

4r7if3x
Copy link
Contributor

@4r7if3x 4r7if3x commented May 15, 2023

Extensive testing on different platforms is required.

4r7if3x and others added 4 commits May 5, 2023 13:40
@GyulyVGC GyulyVGC added the enhancement New feature, request, or improvement label May 15, 2023
@GyulyVGC GyulyVGC added this to the v1.2.0 milestone May 15, 2023
This was linked to issues May 15, 2023
Installing on RHEL based systems #20
Closed
Include WPCAP on installation? #47
Closed
@GyulyVGC GyulyVGC marked this pull request as draft May 15, 2023 13:40
@GyulyVGC
Copy link
Owner

GyulyVGC commented May 15, 2023 •
edited
Loading

Here is a summary of the problems / TODOs:

  • macOS .dmg: completed package automation and tested
  • Linux .rpm: completed package automation and tested. However, it must NOT be built on ubuntu-latest. Building manually on Fedora works just fine instead.
  • Linux .deb: completed package automation. Works on my Kali distro, but on Debian it gives me problems of libssl.so.8 not found (see also Make a container available for easy deployment #69).
  • Windows .msi: I've temporarily commented out the Windows workflow since it needs a secret to install npcap dll, but secrets are not passed to PRs from a fork (I'll personally solve this one as it'll be merged)

@GyulyVGC GyulyVGC marked this pull request as ready for review May 16, 2023 21:27
@GyulyVGC GyulyVGC removed a link to an issue May 16, 2023
Include WPCAP on installation? #47
Closed
@GyulyVGC GyulyVGC merged commit 0058c41 into GyulyVGC:v1.2.0 May 16, 2023
3 checks passed
@GyulyVGC
Copy link
Owner

@all-contributors please add @4r7if3x for platform.

@allcontributors allcontributors bot mentioned this pull request May 17, 2023
Merged
@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @4r7if3x! 🎉

@Porkepix Porkepix mentioned this pull request May 18, 2023
Merged
@4r7if3x 4r7if3x deleted the feature/pkg-dist branch May 19, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GyulyVGC GyulyVGC GyulyVGC approved these changes

Assignees
No one assigned
Labels
enhancement New feature, request, or improvement
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Installing on RHEL based systems
2 participants
@4r7if3x @GyulyVGC