Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Korean translation for additional text #205

Merged
merged 3 commits into from
May 31, 2023

Conversation

eatingdm
Copy link
Contributor

Translate everything into native Korean

Translate everything into native Korean
Copy link

@134130 134130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다.

@@ -105,6 +116,7 @@ pub fn socket_address_translation(language: Language) -> &'static str {
match language {
Language::EN => "Socket address",
Language::IT => "Indirizzo del socket",
Language::KO => "소켓 어드레스",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소켓 주소

@@ -113,6 +125,7 @@ pub fn mac_address_translation(language: Language) -> &'static str {
match language {
Language::EN => "MAC address",
Language::IT => "Indirizzo MAC",
Language::KO => "맥 어드레스",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAC 주소

@@ -137,6 +152,7 @@ pub fn fqdn_translation(language: Language) -> &'static str {
match language {
Language::EN => "Fully qualified domain name",
Language::IT => "Nome di dominio completo",
Language::KO => "절대 도메인 네임",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체 주소 도메인 네임
"절대 도메인 네임" 또한 쓰이는 표현이나, 보편적인 표현을 추천합니다.
개인적으로는 그냥 FQDN이 이해하기 더 편하네요.

@GyulyVGC GyulyVGC merged commit d69f404 into GyulyVGC:main May 31, 2023
3 checks passed
@GyulyVGC
Copy link
Owner

GyulyVGC commented May 31, 2023

@134130 I have merged this PR but please feel free to submit your enhancements in a new PR if you think there is something that can be improved.

@GyulyVGC
Copy link
Owner

@all-contributors please add @eatingdm for translation.

@allcontributors
Copy link
Contributor

@GyulyVGC

I've put up a pull request to add @eatingdm! 🎉

@GyulyVGC GyulyVGC added this to the v1.2.1 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation User interface translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants