fix build failure on powerpc64 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable rustls-tls features of reqwest dependency for ppc64 because of ruslts needs ring, which the latest stable version doesn't support this arch.
dutyrok
changed the title
dutyrok
changed the title
Closed
1 task
GyulyVGC
approved these changes
Aug 27, 2023
|
So, this cargo.lock is built on a target architecture different from powerpc64 and we should keep this version on the repo. Did you try building it also on powerpc64 as a confirmation? Is everything fine? |
|
@all-contributors please add @dutyrok for bug. |
|
I've put up a pull request to add @dutyrok! 🎉 |
Yes, sniffnet has been built on this arch and works (at least in qemu). I put a build log as a proof of build is success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable rustls-tls features of reqwest dependency for ppc64 because of ruslts needs ring, which the latest stable version doesn't support this arch.