Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes when sharing relto book #1005

Merged
merged 1 commit into from Oct 17, 2021
Merged

Fix crashes when sharing relto book #1005

merged 1 commit into from Oct 17, 2021

Conversation

roblabla
Copy link
Contributor

Since host/guest get std::move, the original variables get replaced with null ptrs.
The subsequent accesses causes a crash.

This can be easily tested by sharing a relto book, which will cause a crash due to a null ptr deref on host->GetName().

Since host/guest get std::move, the original variables get replaced with null ptrs.
The subsequent accesses causes a crash.

This can be easily tested by sharing a relto book, which will cause a crash due to a null ptr deref on host->GetName().
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Thanks for the fix!

@Hoikas Hoikas merged commit c797d89 into H-uru:master Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants