Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files updated for Additional Clothing PR #1007

Merged
merged 17 commits into from Dec 15, 2021

Conversation

Hazado
Copy link
Contributor

@Hazado Hazado commented Oct 26, 2021

PRP files - H-uru/moul-assets#85

Found a bug in how clothing is rewarded, before it would check and if you already had it, it would just reward it again anyways. The HasClothing function is the solution that was suggested to me by Adam to fix it.

Clothing Sets code was removed between CC and Moula, found the old cyan code and added it back in.
Its found in xAvatarCustomization.py

Personal.py has some new reward code for clothing sets added by Calum Traveler
Checks if you have the Bahro wedges and if you complete one, it adds it to your closet on first visit to Relto.

Found a bug in how clothing is checked when its rewarded
Added to personal.py the reward checks for new clothing options added by Calum Traveler
Added in xAvatarCustomization.py the code needed for ClothingSets to work again
Copy link
Member

@Hoikas Hoikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a smattering of feedback for xACA.py that will work with Python 2. Considering the dire state this file is already in, I did not give complete feedback. Be sure to convert all of the string adds to the appropriate formatting specifiers.

Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
for newitem in theSet:
if newitem.accessoryType == -1:
lastitem = FindWornItem(newitem.type)
if type(lastitem) != type(None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if type(lastitem) != type(None):
if lastItem is not None:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion did not work.

Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
Scripts/Python/xAvatarCustomization.py Outdated Show resolved Hide resolved
…i Message

Prevents the clothing being hidden when guests click it
Ki Message only when you acquire the first time
@Hoikas Hoikas added the Blocking on MOULa This pull request is accepted but is blocking on an analogous deployment to Cyan's MOULa Shard. label Dec 7, 2021
Clothing Set items wouldnt be removed visually when seen by other players. Linking would fix the visual change.
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/SDL/Myst.sdl Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Scripts/Python/xTakableClothing.py Outdated Show resolved Hide resolved
Hazado and others added 2 commits December 14, 2021 08:03
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
@Hoikas Hoikas merged commit 384618c into H-uru:master Dec 15, 2021
@Hazado Hazado deleted the AdditionalClothingfromCC branch December 16, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking on MOULa This pull request is accepted but is blocking on an analogous deployment to Cyan's MOULa Shard. hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants