Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mouse-free and message-free KI commands to select KI folders: /age, /neighbors, and /buddies #1040

Merged
merged 5 commits into from
Dec 19, 2021

Conversation

ZarothYe
Copy link
Contributor

This allows users to change chat context for future messages without clicking on the KI folders. For example, if you are PMing/whispering to someone, then want to stop whispering and start sending future messages to all Age Players, you can switch context by using "/age<Enter>" and it behaves like you have clicked the AGE PLAYERS folder from your KI list.

Should be merged alongside this moul-assets PR.

@Deledrius
Copy link
Member

Awesome! Looks like this PR has a few extraneous commits in it, though.

Scripts/Python/ki/xKIChat.py Outdated Show resolved Hide resolved
Scripts/Python/ki/xKIChat.py Outdated Show resolved Hide resolved
Scripts/Python/ki/xKIChat.py Outdated Show resolved Hide resolved
ZarothYe and others added 5 commits December 18, 2021 19:16
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
…dicator if finished looping without finding a matching KI folder
@Hoikas
Copy link
Member

Hoikas commented Dec 19, 2021

This looks good in testing. Question, though, when you sent buddy chat via /buddies<enter> then message, the resulting error is different from if you send the message via /buddies hello!<enter>. Is that related to this PR or just some old issue?

image

@ZarothYe
Copy link
Contributor Author

This looks good in testing. Question, though, when you sent buddy chat via /buddies<enter> then message, the resulting error is different from if you send the message via /buddies hello!<enter>. Is that related to this PR or just some old issue?

image

This appears to be just because it's going through different handling in IAddChatLine. See xKIChat line #333 vs line #384. I think it would end up doing the "Everyone in list" message if you clicked the KI "BUDDIES" folder and sent a message rather than using /buddies <message> as well.

@Hoikas Hoikas merged commit 4b83395 into H-uru:master Dec 19, 2021
@ZarothYe ZarothYe deleted the ki-mousefree-folder-select branch January 23, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants