Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Yeesha Page 8 issues #1275

Merged
merged 1 commit into from
Dec 31, 2022
Merged

Conversation

Hazado
Copy link
Contributor

@Hazado Hazado commented Dec 15, 2022

This fixes the issues noted in #1274

Relto Pages in the rainy cleft before would sometimes have the holographic page show instead of the correct solid background.
It could also show the previous symbol used in addition to the holographic page.

This code in my testing fixed the issues.

@Hoikas
Copy link
Member

Hoikas commented Dec 16, 2022

This looks correct to me. Did you verify that the other Yeesha pages still work as expected after clicking on the holographic page?

@Hazado
Copy link
Contributor Author

Hazado commented Dec 16, 2022

This looks correct to me. Did you verify that the other Yeesha pages still work as expected after clicking on the holographic page?

Yes, pages worked as they should.

Relevant Log:

(12/15 18:20:58) DEBUG: clftYeeshaPage08.OnGUINotify(): Picked up page
(12/15 18:20:58) DEBUG: clftYeeshaPage08.py: The previous value of the SDL variable YeeshaPage8 is 2
(12/15 18:20:58) DEBUG: clftYeeshaPage08.py: You've already found Yeesha Page #8. Move along. Move along.
(12/15 18:20:58) DEBUG: clftYeeshaPage08.py: You've already found Yeesha Page #8. Move along. Move along.
(12/15 18:21:07) xYeeshaPages.OnGUINotify(): Picked up page number: 28
(12/15 18:21:07) xYeeshaPages.py: The previous value of the SDL variable YeeshaPage28 is 1
(12/15 18:21:07) xYeeshaPages.py: You've already found Yeesha Page #28. Move along. Move along.
(12/15 18:21:16) clftYeeshaPageImager.OnNotify()
(12/15 18:21:16) ImagerUsable: 1
(12/15 18:21:18) DEBUG: clftYeeshaPage08.OnGUINotify(): Picked up page
(12/15 18:21:18) DEBUG: clftYeeshaPage08.py: The previous value of the SDL variable YeeshaPage8 is 2
(12/15 18:21:18) DEBUG: clftYeeshaPage08.py: You've already found Yeesha Page #8. Move along. Move along.
(12/15 18:21:18) DEBUG: clftYeeshaPage08.py: You've already found Yeesha Page #8. Move along. Move along.
(12/15 18:21:27) xYeeshaPages.OnGUINotify(): Picked up page number: 28
(12/15 18:21:27) xYeeshaPages.py: The previous value of the SDL variable YeeshaPage28 is 1
(12/15 18:21:27) xYeeshaPages.py: You've already found Yeesha Page #28. Move along. Move along.

@Hoikas Hoikas merged commit 437bb98 into H-uru:master Dec 31, 2022
@Hazado Hazado deleted the FixGlitchyYeeshaPages branch January 16, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants