Improved Crash Handling #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfCrashHandler includes a client that watches plClient for crashes. When it detects a crash, it lets the plCrashSrv (plCrashHandler.exe) know about it. We then produce a mninidump, then signal the client that it's OK to show a crash dialog. See http://www.nynaeve.net/?p=128 for a good explanation of why I split the crash logic into another process.
|
Instead of getting a stack error (which I can exit by hitting enter), I am now stuck in a black screen and I have to kill the process. Furthermore, I found no crash dump in my log folder, so I guess there has none been created at all. |
|
Did you copy UruCrashHandler.exe or plCrashHandler.exe to your Uru folder? Uru waits on the crash handler executable to finish working before it tells you anything has gone wrong... In my tests, that delay was unnoticeable. |
|
Yeah, that did it. I missed that the crash handler is in a new executable. |
Deledrius
pushed a commit
to Deledrius/Plasma
that referenced
this pull request
Dec 4, 2012
Improved Crash Handling
Hoikas
pushed a commit
to Hoikas/Plasma
that referenced
this pull request
Dec 13, 2012
Improved Crash Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the not-user-friendly stack trace dialog and its associated unreliable crash handling code. It has been replaced with a watchdog process that creates a Win32 minidump ("crash.dmp") in the log folder on crashes. This is more reliable in the undefined crashed state and should allow us to capture better debug information.
I used http://www.nynaeve.net/?p=128 as a reference for creating this model.