Refactor Pending Loads #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any Cyan ages which rely on paging in/out nodes (minkata?) I can see this having possible side-effects in such a situation... |
|
The only object in Minkata that (should, AFAIK) have SDL state is the soccer ball, and it's in a page that's always loaded. |
|
I know that the city is working with node PageIns/PageOuts... https://github.com/H-uru/moul-scripts/blob/master/Python/city.py#L123 |
|
Those occur before |
|
What's the status of this? Does this still need any specific testing? |
|
After one month of being opened, this will be merged at 12:01am UTC-5 barring any blocking comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in my Relto on MOULa that I have stale physical SDL variables from the Neighborhood ("OrangeCone15") hanging around in the game server blob. This is all well and good except for the fact that the old pending load code would attempt to deliver pending SDL states long after all the pages that are actually in an age are actually loaded. This causes the game to load all the Neighborhood_nb01 keys every second.
So, I have refactored the state delivery code to make more sense and to only attempt to deliver state once when the age is fully loaded. If the age is still loading, states are allowed to remain queued until the age is fully loaded. Anything that fails after the age is fully loaded is tossed out.