Revamp Game.TakeScreenShot #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to fix function name. |
The new version uses plCaptureRender, so we can take screenshots at any size that DX can render to...
|
Updated to fix octal |
|
Aside from the FOV reset for which an optional flag would be nice, this is great. 👍 |
Deledrius
added a commit
that referenced
this pull request
Dec 12, 2013
Revamp Game.TakeScreenShot Fixes #358.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the side-effect of #358 (which should probably be renamed when this is merged).
Instead of doing random stuff like writing out targas and
memcpying all the things, we now useplCaptureRenderto take our screenshot (at any res DX supports). We also write out PNGs because no one uses TGA anymore... For free, you get aspect ratio "fixes" inplCaptureRenderand some includes-reorganization...