Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AniGraph classes from plAvatar -> plAnimation. #457

Merged
merged 1 commit into from
Nov 1, 2014

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 19, 2014

Split things up to allow a bit better organization, and hopefully better linking between libraries.

This definitely needs testing (both client and Max plugin).

@Mystler
Copy link
Contributor

Mystler commented Oct 19, 2014

I get unresolved external symbol errors. Looks like the linking is not working properly yet.


add_library(plAnimation STATIC ${plAnimation_SOURCES} ${plAnimation_HEADERS})

target_link_libraries(plAnimation pnModifier)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these links are unnecessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is sadly not the case on Linux with gcc & clang. Each library must link against its dependencies, and there can be no loops (which was part of the reason for splitting this out).

@Mystler
Copy link
Contributor

Mystler commented Oct 20, 2014

I've had some time to look at the linking problem. You forgot to add #include "plAnimation/plAnimationCreatable.h" to PubUtilLib/inc/plAllCreatables.h

@dpogue
Copy link
Member Author

dpogue commented Oct 24, 2014

Thanks Mystler! Updated :)

@Mystler
Copy link
Contributor

Mystler commented Oct 24, 2014

Great. I can't say anything about the Max plugin, but for the client this gets a happy panda from me. 🐼

@Deledrius
Copy link
Member

The Max plugin builds, and it doesn't appear to have introduced any export regressions.

Hoikas added a commit that referenced this pull request Nov 1, 2014
Move AniGraph classes from plAvatar -> plAnimation.
@Hoikas Hoikas merged commit 453d977 into H-uru:master Nov 1, 2014
@dpogue dpogue deleted the plAnimation branch January 25, 2015 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants