Fix PageInAge ignoring the .age file #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Previously, the client loaded every PRP in the global age specified. Now, we test to ensure that the requested page is listed in the age file. This is relevant considering all of the clothing PRPs going into MOULa. We don't want folks able to bring random clothing files onto Gehn.
Hoikas
force-pushed
the
global-ages-fix
branch
from
18dfa38
to
f3f4086
Compare
|
Updated to fix some linker errors in tools as noticed in Gehn 25 beta |
|
Any ohbjections to merging this? It's currently live on Gehn.25 beta... |
|
This looks good to me. Do you have any idea if there was a purpose behind letting it be so permissive? |
|
I think it was an oversight, honestly. Previously, plRegistry only loaded RegistryPageNodes for files listed in the .age file. It's the RPN loading that has become extremely permissive. I did try to fix that, but it was a huge headache, so I felt this would be a decent solution. |
Deledrius
added a commit
to Deledrius/Plasma
that referenced
this pull request
Jan 30, 2017
Adds missing libraries for plFontConverter and plLocalizationEditor that were overlooked in H-uru#543.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the client loaded every PRP in the global age specified. Now, we test to ensure that the requested page is listed in the age file. This is relevant considering all of the clothing PRPs going into MOULa. We don't want folks able to bring random clothing files onto Gehn. Please note this code path is only used for global ages.