New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KI Easter Egg Updates/Age Constants #682
Conversation
Scripts/Python/ki/xKIConstants.py
Outdated
"Trebivdil" : "Tre'bivdil", | ||
"trebivdil" : "Tre'bivdil", | ||
"vothol" : "Vothol Gallery"} | ||
"vothol" : "Vothol Gallery", | ||
"FehnirHouse" : "Fehnir's House", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vothol Gallery & Fehnir's House are both Cavern locations, no? They should be D'ni-<something>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this convention also extend to the various pubs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point dpogue. Let me test how that looks in Destiny.
EDIT: Things looked good. Added "D'ni-" to the beginning of each location (Pubs, Fehnir, Vothol, GoMePubNew, etc) with the amended commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don’t listen to my bikeshedding, but I don’t think this change is a proper continuation of the previous pattern. In the precedent, the “D'ni-” prefix is followed by a D’ni area name, not by an English description. So the pubs would all become “D'ni-J'taeri” (or whatever it was). The ambiguity would make it less useful though.
(In other words, the change makes things no less inconsistent than before. It does make them marginally more useful, so I guess it’s OK.)
"exits" : "... wait, where ARE the exits? Who built this place anyway?", | ||
"people" : "many people...unless you are here by yourself...in which case, you don't."}, | ||
"ChisoPreniv" : {"see" : "All around you are bookshelves upon bookshelves but not a book to read. To the south is a large set of windows that reveal a vast landscape that you'll never be able to access.", | ||
"exits" : " ... I guess in this library, the only exit is through the window, but let's not do that"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2188681
to
717dcbc
Compare
Adds new Easter Eggs and Age Name Constants for Fan Ages
Adds new Easter Eggs (feathers) and Constants for Fan Ages.
Adds yellow, raven and dove feathers for GoMePubNew, Chiso, and Veelay respectively.
Adds proper name constants for Fehnir's House, GoMePubNew, Chiso and Veelay.
Adds /look comments for GoMePubNew and Chiso.
Adds GoMePubNew, Chiso and Veelay to "No Invite" list.
(proposed) Takes out unneeded "The" from some of the Age Name constants to help them display better in areas of the KI. While it does appear to cut off the latter part of the text in lists, this should eliminate instances where the Age name only displays as "The...".