Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pfVirtualCam1 Effect Plate. #684

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Remove pfVirtualCam1 Effect Plate. #684

merged 1 commit into from
Jul 16, 2020

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Jul 16, 2020

The effect plate was effectively unused until #679. Fixing it to not be gated behind the status log introduced a regression in which the spinning dots and intro video were hidden.

The effect plate was effectively unused until H-uru#679. Fixing it to not be
gated behind the status log introduced a regression in which the
spinning dots and intro video were hidden.
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deledrius
Copy link
Member

Is this the effects plate mentioned in the Transition Manager as the replacement for the old hack?

@dpogue
Copy link
Member

dpogue commented Jul 16, 2020

Is this the effects plate mentioned in the Transition Manager as the replacement for the old hack?

I don't see any mention of this in the Transition Manager. Were you thinking of this comment?

// Semi-hack. We trigger transitions after we've finished loading.
// Problem is the loading all happens in one really long frame, so that
// if we record the time we started, we'll instantly be done next frame,
// even though we triggered just at the "end" of the last frame.
//
// So instead we don't start the clock until we get our first plTimeMsg.

My guess is that the Transition Manager was added later as an improved attempt to hide the screen while the data was being loaded into the renderer, because the implementation (and naming) is essentially identical to this.

@Deledrius
Copy link
Member

I was thinking of this part:

// Note: eventually, I would like to drive these transitions on material //
// animations (it's just a big screen-covering plate with a material, //
// after all). This would allow the artists to specify their own //
// transitions and do really cool effects. However, that would require //
// somehow loading the materials in, and I'm not sure exactly how to do //
// that.... //

@dpogue
Copy link
Member

dpogue commented Jul 16, 2020

Ahh, I think that sort of control over the plate contents is still yet to be implemented (alas, because there were some cool effects like that in the Descent demo)

@Hoikas Hoikas merged commit 530edb8 into H-uru:master Jul 16, 2020
@Hoikas Hoikas deleted the eff-plate branch July 16, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants