-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pfVirtualCam1 Effect Plate. #684
Conversation
The effect plate was effectively unused until H-uru#679. Fixing it to not be gated behind the status log introduced a regression in which the spinning dots and intro video were hidden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this the effects plate mentioned in the Transition Manager as the replacement for the old hack? |
I don't see any mention of this in the Transition Manager. Were you thinking of this comment? Plasma/Sources/Plasma/PubUtilLib/plPipeline/plTransitionMgr.cpp Lines 260 to 265 in c835484
My guess is that the Transition Manager was added later as an improved attempt to hide the screen while the data was being loaded into the renderer, because the implementation (and naming) is essentially identical to this. |
I was thinking of this part: Plasma/Sources/Plasma/PubUtilLib/plPipeline/plTransitionMgr.cpp Lines 46 to 51 in c835484
|
Ahh, I think that sort of control over the plate contents is still yet to be implemented (alas, because there were some cool effects like that in the Descent demo) |
The effect plate was effectively unused until #679. Fixing it to not be gated behind the status log introduced a regression in which the spinning dots and intro video were hidden.