Fixed b0rked hoods on MOULa. #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue seems to only affect Cyan's server (aka MOULa). Per Susa'n, the Cavern Events Hood [sic] on MOULa will only appear in the Nexus when the Age is occupied. Once the last player leaves the Age, it is removed from the list. Upon further investigation by @cwalther and myself, we determined that the server is incorrectly reporting the owner count of the "b0rked" Neighborhoods as zero. On a quick investigation, we found three affected Neighborhoods currently in the list on MOULa. However, more Neighborhoods are known to be affected. Per discussion on discord, it makes more sense to NOT filter Neighborhoods in this way in the Nexus. Rather, we should simply allow natural selection to cull inactive Neighborhoods from the list.
|
For future reference, this is the output I got from dumping the MOULa Neighborhood public Age list: https://gist.github.com/Hoikas/0d575eac5b7c231702f2d832dd0544fb |
cwalther
approved these changes
Sep 12, 2020
DoobesURU
approved these changes
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue seems to only affect Cyan's server (aka MOULa). Per Susa'n, the Cavern Events Hood [sic] on MOULa will only appear in the Nexus when the Age is occupied. Once the last player leaves the Age, it is removed from the list. Upon further investigation by @cwalther and myself, we determined that the server is incorrectly reporting the owner count of the "b0rked" Neighborhoods as zero. On a quick investigation, we found three affected Neighborhoods currently in the list on MOULa. However, more Neighborhoods are known to be affected.
Per discussion on discord, it makes more sense to NOT filter Neighborhoods in this way in the Nexus. Rather, we should simply allow natural selection to cull inactive Neighborhoods from the list.