Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation (Yes/No/OK/Quit/Logout) Overhaul #884

Merged
merged 6 commits into from
Jun 16, 2021
Merged

Confirmation (Yes/No/OK/Quit/Logout) Overhaul #884

merged 6 commits into from
Jun 16, 2021

Commits on May 30, 2021

  1. Implement pfConfirmationMgr. 

    pfConfirmationMgr is designed to replace the ad-hoc Yes/No dialog
implementation in xKI. Currently, the KI handles throwing up its own
dialogs and can respond to pfKIMsgs sent with a kYesNo type. The result
is the handling of confirmation dialogs is:

- Dependent on having a functioning KI python.
- Spread over many hundreds of lines of python.
- Requires having a plKey to receive a response.

These limitations make doing things that require confirmation annoying.
This system will allow you to dispatch a confirmation dialog from
anywhere in the engine that links against plMessage and receive the
results either in a (potentially stateful) lambda or via a legacy
notification message.
    @Hoikas
    Hoikas committed May 30, 2021
    Configuration menu
    Copy the full SHA
    9ef5c8d View commit details
    Browse the repository at this point in the history

  2. Move Python variadic helpers to a new file. 

    This will allow them to be reused more easily.
    @Hoikas
    Hoikas committed May 30, 2021
    Configuration menu
    Copy the full SHA
    e19da3f View commit details
    Browse the repository at this point in the history

  3. ConfirmationMgr-ize PtYesNoDialog() python bindings. 

    This also includes the first stab at some general code that allows
firing an arbitrary callback from the engine into Python code without
leaking resources.
    @Hoikas
    Hoikas committed May 30, 2021
    Configuration menu
    Copy the full SHA
    4eacb21 View commit details
    Browse the repository at this point in the history

  4. Remove xKI's ad-hoc Yes/No dialog proc. 

    This conflicts with what we're doing in pfConfirmationMgr and therefore
*MUST* be replaced in order for everything to work correctly.
    @Hoikas
    Hoikas committed May 30, 2021
    Configuration menu
    Copy the full SHA
    2280beb View commit details
    Browse the repository at this point in the history

  5. Use new yes/no handling in StartUp. 

    Low-hanging fruit and improves our localization coverage.
    @Hoikas
    Hoikas committed May 30, 2021
    Configuration menu
    Copy the full SHA
    22809b4 View commit details
    Browse the repository at this point in the history

  6. Fix non-MSVC build errors.

    @Hoikas
    Hoikas committed May 30, 2021
    Configuration menu
    Copy the full SHA
    0138f5a View commit details
    Browse the repository at this point in the history