Add new menorah flame SDL state #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Oct 7, 2021
Removed depreciated states
DoobesURU
force-pushed
the
GoMePubNew2021
branch
from
004891d
to
2edeb80
Compare
Hoikas
added
the
Blocking on MOULa
Hoikas
approved these changes
Dec 13, 2021
Hoikas
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again condenses a bunch of SDL states into one, this time for the menorah candle flames.
Instead of each flame being a separate bool SDL, everything is now controlled by an integer "gmpnMenFlameStat". The menorah itself is still controlled by the gmpnHolidayVis state.
0 - Default (no flames)
1 - Shammash and Flame01 on Day 1
2 - Flame02 on Day 2
3 - Flame03 on Day 3
4 - Flame04 on Day 4
5 - Flame05 on Day 5
6 - Flame06 on Day 6
7 - Flame07 on Day 7
8 - Flame08 on Day 8
New PRPs to go along with this will be PRed later after I do a few more adjustments to collision to keep the cones and Eddie out of weird spots.