Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes for tedana and templateflow, allow mamba debugging #704

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

lalalavi
Copy link
Collaborator

Not necessary to merge this now, just want to see if it passes integration tests

@HippocampusGirl
Copy link
Member

Awesome! Are you sure we're not missing any runtime dependencies? I'm fairly certain templateflow needs pybids

@lalalavi
Copy link
Collaborator Author

Yeah you are right, i was able to build the package locally but not install it. Mamba said it was about python though, not pybids (but it looks it is a dependency judging from this.

I am still figuring out how flexible is the dependency on pybids, because they have a conda recipe starting form 0.15.6 so maybe we can avoid building ourselves (in anyway, right now if you look at it, it is not using our local build even though it succeeds, it still defaults to pypi)

@HippocampusGirl
Copy link
Member

Still, this is great progress! Have you considered creating a halfpipe recipe and then removing install_dependencies.sh, and the requirements.txt (and similar) files? Then you just need to repair everything until tests run again :-)

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.66%. Comparing base (73788d2) to head (af0d7c3).
Report is 11 commits behind head on main.

❗ Current head af0d7c3 differs from pull request most recent head a397183. Consider uploading reports for the commit a397183 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   60.57%   60.66%   +0.09%     
==========================================
  Files         244      245       +1     
  Lines       15437    15570     +133     
  Branches     2987     3018      +31     
==========================================
+ Hits         9351     9446      +95     
- Misses       5375     5411      +36     
- Partials      711      713       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants