Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving robustness of Windows build pipeline #92

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

GustavoSilvera
Copy link
Collaborator

Finding the most common points of failure in a default Windows build pipeline (zlib, xerces, osm2odr, PythonAPI) and patching them.

  1. Added archive link for zlib 1.2.1.1 (here) and Xerces 3.2.3 (here) to follow the compatibilities from 0.9.13
  2. Prefer building PythonAPI with python rather than Windows built-in py -3 (better for conda) but fallback if python is not available (here)
  3. Create missing directory in PythonAPI if it does not exist, this would otherwise result in a silent error that wouldn't get "fixed" until running make PythonAPI again (here)
  4. Add transcoder=windows build flag for xerces (more reliable than the default of ICU) (here)

Also fixed a crash when there was already an EgoVehicle in the map before BeginPlay was called.

@GustavoSilvera GustavoSilvera added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request installation Issues with installing DReyeVR to Carla labels Mar 18, 2023
@GustavoSilvera GustavoSilvera self-assigned this Mar 18, 2023
reflects default Windows PythonAPI build python is changed to `python` rather than `py -3`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request installation Issues with installing DReyeVR to Carla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants