Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization agent #40

Closed
argenos opened this issue Nov 14, 2018 · 9 comments
Closed

Visualization agent #40

argenos opened this issue Nov 14, 2018 · 9 comments

Comments

@argenos
Copy link
Member

argenos commented Nov 14, 2018

The following visualization proposals were accepted:

The pull request should also contain their interfaces added to the base class (#39), so other teams can seamlessly integrate it into their projects.

The selected framework is JavaFX.

@argenos
Copy link
Member Author

argenos commented Nov 14, 2018

@HBRS-MAAS to clarify the deadline: although the complete functionality does not need to be there by next week, your messages and a prototype of your agent which can receive them are a good start for this assignment.

In case you don't want to implement the issue that was assigned to you, please write on this thread so other teams who might be interested can switch if they want. NB some of this might be converted into an assignment later on if not taken up by someone.

Sushant-Chavan pushed a commit to Sushant-Chavan/project that referenced this issue Nov 19, 2018
@anenriquez
Copy link
Contributor

@HBRS-MAAS/mas_maas has decided to not implement their visualization issue.

@madmax2012
Copy link
Contributor

@HBRS-MAAS/team_pjt Will implement their visualization task

@tmeule2s
Copy link

did anyone fix the build issue with javafx yet?

@argenos
Copy link
Member Author

argenos commented Jan 29, 2019

@HBRS-MAAS/ws18 please make sure that the README contains instructions on how to run your interface agents and visualization components. Remember that only interfaces and visualization that are merged and runnable from this repository will be counted. Deadline for this is Thursday 18:00.

@anenriquez
Copy link
Contributor

Does the visualization agent should run in this repository? We have created the visualization for the doughPrep stage using the agents of our architecture, i.e., the visualizator not only receives messages from the proofer agent but also from other agents in our internal architecture. If we add visualization to upstream we would also need to include the internal agents of our doughPrep stage to this repository. Is this correct? Thanks!

@argenos
Copy link
Member Author

argenos commented Jan 29, 2019

No need to add your project agents here, however, the visualization should run even if it doesn't receive any updates. Keep in mind that, at least in theory, your interface agents should talk to your visualization component (I am aware that not all visualizations do this).

Your interface agents are a different story, those should run, regardless of the existance of your other agents.

@argenos argenos closed this as completed Jan 29, 2019
Project contributions and common agents automation moved this from To do to Done Jan 29, 2019
@argenos argenos reopened this Jan 29, 2019
Project contributions and common agents automation moved this from Done to In progress Jan 29, 2019
@anenriquez
Copy link
Contributor

Thanks for the quick reply. Unfortunately, our visualization will not work if it does not receive the messages sent by our agents. I opened a pull request with everything that the visualization needs. However, we understand if this is not sufficient for getting the visualization points.

@anenriquez
Copy link
Contributor

Should we make the pull request to develop or to master? I have opened a new pull request to develop. Should I modify it to be merged into master? Thanks!

@argenos argenos closed this as completed May 22, 2019
Project contributions and common agents automation moved this from In progress to Done May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants