Skip to content

Commit

Permalink
Merge pull request #91 from HBehrens/noahp/remove-python3.6
Browse files Browse the repository at this point in the history
Remove python 3.6 support
  • Loading branch information
noahp committed Oct 18, 2023
2 parents 4b245a9 + c7219f8 commit 2d0d108
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 14 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
# note: 3.5 + 3.6 are EOL as of 2022-09-16. tests do fail on python3.5,
# see https://github.com/HBehrens/puncover/issues/36
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"]
# it's convenient to stay on an older ubuntu as long as we need
# python3.6:
# https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
Expand All @@ -37,7 +35,7 @@ jobs:
- name: Install dependencies
run: |
# bind pip to a specific version to hopefully avoid breakage
pip install -r .github/workflows/requirements-pip.txt
pip install pip==23.3
pip install -r requirements-test.txt
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/requirements-pip.txt

This file was deleted.

1 change: 0 additions & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
3.6.15
3.7.17
3.8.18
3.9.18
Expand Down
5 changes: 1 addition & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ def run(self):
"License :: OSI Approved :: MIT License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
Expand All @@ -69,7 +68,5 @@ def run(self):
cmdclass={
"clean": CleanCommand,
},
# TODO: https://github.com/HBehrens/puncover/issues/36
# Fix Python 3.5
python_requires=">=3.6",
python_requires=">=3.7",
)

0 comments on commit 2d0d108

Please sign in to comment.