Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions run on PR, and mac #65

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

noahp
Copy link
Collaborator

@noahp noahp commented Dec 20, 2022

Previously actions was only running on pushes. Tidy that up and make it
run on PR's as well.

Run tests on mac as well- added a windows run to the matrix, but it
fails due to path mismatch issues, which are addressed in other PRs, so
leaving it disabled here.

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 81.75% // Head: 81.75% // No change to project coverage 👍

Coverage data is based on head (769820b) compared to base (ec63f21).
Patch has no changes to coverable lines.

❗ Current head 769820b differs from pull request most recent head fc0f303. Consider uploading reports for the commit fc0f303 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files          11       11           
  Lines        1239     1239           
=======================================
  Hits         1013     1013           
  Misses        226      226           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Previously actions was only running on pushes. Tidy that up and make it
run on PR's as well.

Run tests on mac as well- added a windows run to the matrix, but it
fails due to path mismatch issues, which are addressed in other PRs, so
leaving it disabled here.
@noahp noahp force-pushed the noahp/actions-pr-and-mac-windows branch from 769820b to fc0f303 Compare December 20, 2022 20:05
@noahp noahp marked this pull request as ready for review December 20, 2022 20:07
@noahp noahp requested a review from HBehrens December 20, 2022 20:07
@noahp noahp changed the title Add actions run on PR, and mac and windows Add actions run on PR, and mac Dec 20, 2022
@noahp noahp merged commit 2e5f6be into master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant