-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathlib port (Windows/Linux/MacOS) #70
Conversation
- Changed tests for Collector class with pathlib. - Added copyright and mantainer info for further contact of the changes of this commit.
…he stack usage tests.
I did a local pull request on my fork and it fails for windows with python 3.6,3.7 and 3.9 https://github.com/vChavezB/puncover/actions/runs/3745394220/jobs/6359786909 I will have a look on this... |
Ok I think the pipeline should now pass :) |
Codecov ReportBase: 81.75% // Head: 81.57% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 81.75% 81.57% -0.19%
==========================================
Files 11 11
Lines 1239 1297 +58
==========================================
+ Hits 1013 1058 +45
- Misses 226 239 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
You can ignore that codecov check error by the way! I'll take a look at this patch soon. Looks solid though if it's passing all the tests on our 18 (!) supported configurations, amazing work! |
Love it, thank you so much! merging now |
Based on the comments from @noahp I have rebased my last pull request to veriify that unit tests pass for different versions with github actions and python module tox.
Changes
Fixed