Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathlib port (Windows/Linux/MacOS) #70

Merged
merged 12 commits into from
Mar 2, 2023
Merged

Conversation

vChavezB
Copy link
Contributor

@vChavezB vChavezB commented Dec 20, 2022

Based on the comments from @noahp I have rebased my last pull request to veriify that unit tests pass for different versions with github actions and python module tox.

Changes

Fixed

  • Unit tests due to parsing of basefile name as a pathlib type. Changed to string representation.
  • Path for elf file was not working in windows. Parsing elf_file_path as pathlib to have a generic path representation to fix this.

@vChavezB
Copy link
Contributor Author

I did a local pull request on my fork and it fails for windows with python 3.6,3.7 and 3.9

https://github.com/vChavezB/puncover/actions/runs/3745394220/jobs/6359786909

I will have a look on this...

@vChavezB
Copy link
Contributor Author

Ok I think the pipeline should now pass :)

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 81.75% // Head: 81.57% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (d8bc167) compared to base (6f53a5f).
Patch coverage: 79.24% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   81.75%   81.57%   -0.19%     
==========================================
  Files          11       11              
  Lines        1239     1297      +58     
==========================================
+ Hits         1013     1058      +45     
- Misses        226      239      +13     
Impacted Files Coverage Δ
puncover/gcc_tools.py 63.33% <0.00%> (-4.53%) ⬇️
puncover/renderers.py 54.21% <33.33%> (-0.04%) ⬇️
puncover/collector.py 74.32% <65.95%> (-0.44%) ⬇️
tests/test_collector.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@noahp
Copy link
Collaborator

noahp commented Dec 23, 2022

You can ignore that codecov check error by the way! I'll take a look at this patch soon. Looks solid though if it's passing all the tests on our 18 (!) supported configurations, amazing work!

@noahp
Copy link
Collaborator

noahp commented Mar 2, 2023

Love it, thank you so much! merging now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants