Handle .su files with full file paths #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some build systems (Zephyr) will emit full paths into the .su files: ```plaintext /home/noah/zephyr/qemu/qemu-app/src/main.c:184:13:prv_run_stack_metrics_example 1032 static /home/noah/zephyr/qemu/qemu-app/src/main.c:147:12:prv_run_example_memory_metrics 16 static /home/noah/zephyr/qemu/qemu-app/src/main.c:60:6:memfault_platform_get_device_info 8 static /home/noah/zephyr/qemu/qemu-app/src/main.c:178:6:memfault_metrics_heartbeat_collect_data 96 dynamic,bounded /home/noah/zephyr/qemu/qemu-app/src/main.c:190:6:main 48 dynamic,bounded ``` This breaks the .su parsing code. Add a fix to match on the basename instead.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
- Coverage 81.57% 81.51% -0.07%
==========================================
Files 11 11
Lines 1297 1298 +1
==========================================
Hits 1058 1058
- Misses 239 240 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build systems (Zephyr) will emit full paths into the .su files:
This breaks the .su parsing code. Add a fix to match on the basename
instead.